Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow passing param depth to go_to_context() #277

Merged
merged 4 commits into from
Dec 23, 2023

Conversation

Bekaboo
Copy link
Contributor

@Bekaboo Bekaboo commented May 15, 2023

Implement #276.

@Bekaboo
Copy link
Contributor Author

Bekaboo commented Jun 17, 2023

@lewis6991 Any thoughts / advice on this?

@amaanq
Copy link
Member

amaanq commented Jul 5, 2023

Hmm, doesn't vim.iter break 0.8.2 compatibility (not that I care, tree-sitter stuff is experimental anyways, just double checking)

@Bekaboo
Copy link
Contributor Author

Bekaboo commented Jul 5, 2023

Hmm, doesn't vim.iter break 0.8.2 compatibility (not that I care, tree-sitter stuff is experimental anyways, just double checking)

@amaanq Good point, will fix this later. Also, do you think that it is better to use vim.v.count1 as the fallback of depth?

@amaanq
Copy link
Member

amaanq commented Jul 12, 2023

Sorry about the delay - I wasn't aware that that's a thing, but is that not just 1?

@lewis6991
Copy link
Member

Will merge if this is updated and fixed. Otherwise I'll close this as stale.

@Bekaboo
Copy link
Contributor Author

Bekaboo commented Dec 8, 2023

@lewis6991 Sorry for the latency, please don't close this. I am interested in improving this PR but quite busy this week. Will work on this in two weeks or so.

@Bekaboo
Copy link
Contributor Author

Bekaboo commented Dec 23, 2023

@lewis6991 @amaanq Removed usage of vim.iter() and solved conflicts with master

@lewis6991 lewis6991 merged commit 652ec51 into nvim-treesitter:master Dec 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants