[Robustness] handle an overridden `type` #2356

ljharb · 2020-11-21T21:54:32Z

Fixes #2352

sladyn98 · 2021-03-01T15:45:45Z

Looks like the tests are failing on this one.

sladyn98 · 2021-03-16T13:42:56Z

@ljharb Let me know if you need help to push this one over the line

nvm.sh

ljharb · 2021-03-18T17:55:10Z

@sladyn98 still failing; happy to get some help on this one :-)

sladyn98 · 2021-03-18T17:56:12Z

Yeah now all of the zsh tests are unhappy :(

ljharb · 2021-03-18T17:59:14Z

i think maybe the reason i didn't have command type in nvm_has before was because it doesn't work in zsh :-/

[Robustness] handle an overridden type

c8d70e0

Fixes nvm-sh#2352

ljharb force-pushed the master branch from a09e064 to 49e806c Compare February 1, 2021 22:36

ljharb force-pushed the type_override branch from b7100e9 to 236c16e Compare February 19, 2021 17:05

ljharb mentioned this pull request Mar 1, 2021

type alias conflicts with nvm #2352

Open

sladyn98 reviewed Mar 18, 2021

View reviewed changes

nvm.sh Outdated Show resolved Hide resolved

ljharb force-pushed the type_override branch 3 times, most recently from 5f62dab to c8d70e0 Compare March 18, 2021 16:26

ljharb force-pushed the master branch from d3710f8 to 07253ec Compare April 16, 2021 05:45

This comment was marked as spam.

Sign in to view

ljharb force-pushed the master branch from 7846e33 to 1f970cc Compare November 1, 2023 22:11

ljharb force-pushed the master branch 2 times, most recently from c6cfc3a to c20db2a Compare June 10, 2024 18:13

Provide feedback