Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: headless_shell_switches.cc was deleted in branch nw73 #163

Open
wants to merge 1 commit into
base: nw83
Choose a base branch
from

Conversation

dyk98
Copy link

@dyk98 dyk98 commented Dec 27, 2023

fix issue 162
headless_shell_switches.cc and headless_shell_switches.h was deleted in branch nw73
If you run ninja -C out/nw nwjs will throw error about ninja: error: '../../headless/app/headless_shell_switches.cc', needed by 'obj/headless/headless_shell_lib/headless_shell_switches.o', missing and no known rule to make it

@ayushmanchhabra
Copy link

I think this has already been addressed in #93. @rogerwang can we get this merged and close the previous PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants