[linux] enabled global menubar on Ubuntu #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposed APIs for global menubar on Ubuntu. This patch also removed global menubar for DevTools window. fixed partially on nwjs/nw.js#2718
GnorTech
pushed a commit
that referenced
this pull request
Apr 26, 2017
Calls to navigator.vibrate will immediately return 'false' if user hasn't tapped on the frame or any embedded frame yet. The implementation is behind an experimental flag. The Intent to Deprecate thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik BUG=704650 Review-Url: https://codereview.chromium.org/2778693004 Cr-Commit-Position: refs/heads/master@{#465618} (cherry picked from commit c5b5911) Review-Url: https://codereview.chromium.org/2825403002 . Cr-Commit-Position: refs/branch-heads/3071@{#54} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech
pushed a commit
that referenced
this pull request
Aug 5, 2017
Was caused by touchscreen_gesture_target_queue_ + prevent default. The webview target was calculated on TouchStart and pushed to the the queue. It was removed on its corresponding GestureTapDown. However, if the TouchStart had default behavior prevented, no GestureTapDown would ever occur, and the queue would forever have an extra element. Fixed by converting touchscreen_gesture_target_queue_ to a map with unique_touch_event_id as keys and gesture target data as values. Also updates AUTHORS file. [email protected] (cherry picked from commit 09a2f88) Bug: 736623, 739831 Change-Id: If3bf844e2bcfb9a1ca6d6a56cdc7575e0767e6b6 Reviewed-on: https://chromium-review.googlesource.com/547669 Commit-Queue: James MacLean <[email protected]> Reviewed-by: Charlie Reis <[email protected]> Reviewed-by: Ken Buchanan <[email protected]> Reviewed-by: James MacLean <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#488759} Reviewed-on: https://chromium-review.googlesource.com/586747 Cr-Commit-Position: refs/branch-heads/3163@{#54} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech
pushed a commit
that referenced
this pull request
Sep 14, 2017
This does not fix the animation if the note app was started via a stylus eject. [email protected] (cherry picked from commit 322df5d) Bug: 762097 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie77c765d3b3d65cf0e7be038e384c94b7d5103c5 Reviewed-on: https://chromium-review.googlesource.com/650647 Reviewed-by: Toni Barzic <[email protected]> Commit-Queue: Jacob Dufault <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#499811} Reviewed-on: https://chromium-review.googlesource.com/653212 Reviewed-by: Jacob Dufault <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{#54} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech
pushed a commit
that referenced
this pull request
Oct 27, 2017
Pressing the app button would try to exit WebVR, which would trigger a non-optional DOFF, which is a really bad user experience. The button should just be disabled when it can't actually take you back to the VR browser. [email protected] (cherry picked from commit a0cdfa5) Bug: 767896 Change-Id: If31a7e8959293efb48618ec40a3cd9e132e92961 Reviewed-on: https://chromium-review.googlesource.com/718986 Reviewed-by: Christopher Grant <[email protected]> Commit-Queue: Michael Thiessen <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#509072} Reviewed-on: https://chromium-review.googlesource.com/726481 Reviewed-by: Michael Thiessen <[email protected]> Cr-Commit-Position: refs/branch-heads/3239@{#54} Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang
pushed a commit
that referenced
this pull request
Jan 29, 2018
[email protected] Change-Id: I669654c9372db4f4097ac177f02a478c3d93e9fc Reviewed-on: https://chromium-review.googlesource.com/882761 Reviewed-by: [email protected] <[email protected]> Cr-Commit-Position: refs/branch-heads/3325@{#54} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech
pushed a commit
that referenced
this pull request
Mar 20, 2018
Bug: 818232 Change-Id: I735f717445cc4e7c1329af836b37b31f1be3612b Reviewed-on: https://chromium-review.googlesource.com/946683 Commit-Queue: Yash Malik <[email protected]> Commit-Queue: Michael Thiessen <[email protected]> Reviewed-by: Michael Thiessen <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#540607}(cherry picked from commit 6a640bd) Reviewed-on: https://chromium-review.googlesource.com/952746 Reviewed-by: Yash Malik <[email protected]> Cr-Commit-Position: refs/branch-heads/3359@{#54} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang
pushed a commit
that referenced
this pull request
Apr 25, 2018
Gives the omnibox a soft shadow. Bug: 833375 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I17b9bbf4fdd2d8830e0157ddfd6b9ef57008ecb2 Reviewed-on: https://chromium-review.googlesource.com/1014010 Commit-Queue: Christopher Grant <[email protected]> Reviewed-by: Christopher Grant <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#551010}(cherry picked from commit a9741a3) Reviewed-on: https://chromium-review.googlesource.com/1015186 Reviewed-by: Ian Vollick <[email protected]> Cr-Commit-Position: refs/branch-heads/3396@{#54} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang
pushed a commit
that referenced
this pull request
Jun 19, 2018
This cl fixes a bug to set logo view alpha value. [email protected], [email protected] Bug: b/80430044, 847609 Test: manual. Change-Id: I25a6e3d64d062f44da48154af42caf3431e14904 Reviewed-on: https://chromium-review.googlesource.com/1077267 Reviewed-by: Xiaohui Chen <[email protected]> Reviewed-by: Xiyuan Xia <[email protected]> Commit-Queue: Tao Wu <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#562632}(cherry picked from commit d7c083c) Reviewed-on: https://chromium-review.googlesource.com/1079855 Reviewed-by: Tao Wu <[email protected]> Cr-Commit-Position: refs/branch-heads/3440@{#54} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech
pushed a commit
that referenced
this pull request
Aug 4, 2018
[email protected] Change-Id: I49e78199a3b3e54a4424ad73a10d39ff46a4e225 Reviewed-on: https://chromium-review.googlesource.com/1149043 Reviewed-by: [email protected] <[email protected]> Cr-Commit-Position: refs/branch-heads/3497@{#54} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang
pushed a commit
that referenced
this pull request
Sep 15, 2018
[email protected] Change-Id: I54dc29eb20958f3c3b7950b8b40cf64e91a8effe Reviewed-on: https://chromium-review.googlesource.com/1207194 Reviewed-by: [email protected] <[email protected]> Cr-Commit-Position: refs/branch-heads/3538@{#54} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang
pushed a commit
that referenced
this pull request
Oct 31, 2018
…simplify UrlValidityChecker testing Fix crashes caused by |url_checker_for_testing_| not being initialized properly. Additionally, construct UrlValidityChecker with NoDestructor instead of a global LazyInstance. We prefer to leak singletons to avoid unnecessary work at shutdown. Also simplify UrlValidityChecker by passing TickClock, which provides cleaner timeout and duration testing. Bug: 894742 Change-Id: I468f76e07dc6f551a8515d8416d0c67f5f2035a1 Reviewed-on: https://chromium-review.googlesource.com/c/1277959 Commit-Queue: Kristi Park <[email protected]> Reviewed-by: Mathieu Perreault <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#599377}(cherry picked from commit 8c7eeb6) Reviewed-on: https://chromium-review.googlesource.com/c/1284063 Reviewed-by: Kristi Park <[email protected]> Cr-Commit-Position: refs/branch-heads/3578@{#54} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang
pushed a commit
that referenced
this pull request
Dec 18, 2018
[email protected] Open the application select menu of chrome shortcut will trigger the window stacking change. It will update the shelf visibility before showing the menu. Call UpdateVisibilityState after the menu is shown to keep the auto-hide shelf shown. (cherry picked from commit 2be72dc) Bug: 908681 Change-Id: I1e4dca91a03ca85df5ddb1511bd2b4f3fe6c8d63 Reviewed-on: https://chromium-review.googlesource.com/c/1356595 Commit-Queue: Min Chen <[email protected]> Reviewed-by: Xiyuan Xia <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#613320} Reviewed-on: https://chromium-review.googlesource.com/c/1362456 Reviewed-by: Min Chen <[email protected]> Cr-Commit-Position: refs/branch-heads/3626@{#54} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang
pushed a commit
that referenced
this pull request
Feb 10, 2019
This reverts commit 066fecf. Reason for revert: This change had some unintended effects on the interaction of WebRequest and URLLoaderThrottles. Original change's description: > Fix WebRequestProxyingURLLoaderFactory crash after redirect > > When OnReceiveRedirect() is called, we expect to not receive any more > events for that request until FollowRedirect() has been called and the > request is restarted with the new URL. We were not clearing the > bindings in this case, so the URLLoader was staying alive and calling > OnBeforeSendHeaders() on the redirected URL. This could then result in > OnBeforeSendHeaders() being called twice, once for the original request > which gets redirected in //net, and once for the request in the correct > flow when it gets restarted after FollowRedirect(). > > I believe this is pretty similar to the issue described in > http://crbug.com/882661, except this one has to do with normal > redirects instead of webRequest generated redirects. > > The existing redirect tests catch this issue when using the > 'extraHeaders' spec, so I made a version of them that runs with that > enabled. > > Bug: 918761 > Change-Id: Ifa551400e85c13ea3a297fba02a05deb5ccb1821 > Reviewed-on: https://chromium-review.googlesource.com/c/1409915 > Reviewed-by: Ken Rockot <[email protected]> > Commit-Queue: Clark DuVall <[email protected]> > Cr-Commit-Position: refs/heads/master@{#622685} [email protected],[email protected] # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 918761 Change-Id: Ie8449c6fd6c94722ef8eb618ea1a16d429b74bbb Reviewed-on: https://chromium-review.googlesource.com/c/1443913 Reviewed-by: Clark DuVall <[email protected]> Reviewed-by: John Abd-El-Malek <[email protected]> Commit-Queue: Clark DuVall <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#627183}(cherry picked from commit 6406a9f) Reviewed-on: https://chromium-review.googlesource.com/c/1444812 Cr-Commit-Position: refs/branch-heads/3683@{#54} Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang
pushed a commit
that referenced
this pull request
Mar 24, 2019
Currently, we compute the intersection of a frame with the top-level viewport in two places: once to control throttling of off-screen iframes, and again to propagate viewport intersection information to OOPIF's, to use for running the IntersectionObserver algorithm. With this CL, the viewport intersection is computed once for both consumers. Cherry-picked from: https://chromium-review.googlesource.com/c/chromium/src/+/1504503 BUG=926539 [email protected] Change-Id: Ia7b964a59647d5efb05279f28652e07031181872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518715 Reviewed-by: Stefan Zager <[email protected]> Cr-Commit-Position: refs/branch-heads/3729@{#54} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed APIs for global menubar on Ubuntu. This patch also removed
global menubar for DevTools window.
fixed partially on nwjs/nw.js#2718