Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(angular-ionic): installation #1128

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Conversation

rbalet
Copy link
Contributor

@rbalet rbalet commented Oct 8, 2024

Description

Add a new entry in the documentation about how to instal and use the angular-ionic library.

Attempt to close: #1123

Copy link

nx-cloud bot commented Oct 8, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6dae377. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

docs/docs/ionic-angular/installation.md Outdated Show resolved Hide resolved
docs/docs/ionic-angular/installation.md Outdated Show resolved Hide resolved
docs/docs/ionic-angular/installation.md Outdated Show resolved Hide resolved
docs/docs/ionic-angular/installation.md Outdated Show resolved Hide resolved
docs/docs/ionic-angular/installation.md Outdated Show resolved Hide resolved
docs/docs/ionic-angular/installation.md Outdated Show resolved Hide resolved
@rbalet
Copy link
Contributor Author

rbalet commented Oct 9, 2024

Hey @edbzn I've implemented your fix proposition.

That said, do you understand why the pipeline failed ?

@edbzn
Copy link
Member

edbzn commented Oct 9, 2024

It fails because the docs include a dead link /docs/capacitor/overview, we need to merge my other PR first.

@edbzn edbzn merged commit 6d12684 into nxext:main Oct 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

capacitor: explain that we have to add plugin as devDependencies
2 participants