Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nxext): migrate workspace to nx 20 #1136

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

pawel-twardziak
Copy link
Contributor

No description provided.

@pawel-twardziak pawel-twardziak marked this pull request as draft October 13, 2024 14:21
Copy link

nx-cloud bot commented Oct 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b4ca04a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pawel-twardziak pawel-twardziak changed the title Migrate workspace to nx 20 chore(nxext): migrate workspace to nx 20 Oct 13, 2024
@pawel-twardziak pawel-twardziak force-pushed the chore/migrate-to-nx-20 branch 4 times, most recently from d3fcc42 to 1823cfe Compare October 13, 2024 17:40
@pawel-twardziak pawel-twardziak marked this pull request as ready for review October 13, 2024 18:12
Copy link
Member

@edbzn edbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @pawel-twardziak!

Note for before merge: we should squash and create a commit including the BREAKING CHANGE: ... in order to bump a major version.

packages/capacitor/package.json Outdated Show resolved Hide resolved
packages/ionic-angular/package.json Outdated Show resolved Hide resolved
@pawel-twardziak
Copy link
Contributor Author

pawel-twardziak commented Oct 13, 2024

Nice work @pawel-twardziak!

Note for before merge: we should squash and create a commit including the BREAKING CHANGE: ... in order to bump a major version.

Sure thing, will squash all the commits soon 👍

@pawel-twardziak
Copy link
Contributor Author

@edbzn squashed 👍

Closes nxext#1134

BREAKING CHANGE: generator option 'name' is optional in favor of 'directory' one
@edbzn edbzn merged commit b6104d2 into nxext:main Oct 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants