chore(deps): delete findbugs #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the findbugs plugin. Findbugs is superseded by SpotBugs. This is a dead build phase dependency. Spotbugs forked the dead findbugs. Even findbugs says to use spotbugs, which we already do. Before this change we are checking twice, once with a decade out of date version (findbugs).
mtrigueira
force-pushed
the
remove-findbugs
branch
from
aed10f5 to
41d26c7
Compare
This change updates the findbugs annotations to spotbugs-annotations. Also the version number is updated to latest. Maven indicates the artifact has been moved as expressed in this change https://mvnrepository.com/artifact/com.google.code.findbugs/jsr305
|
Separate commit to convert annotations to spotbugs. It's related, but different. Can do separate pull, or squash if preferred. This change updates the findbugs annotations to spotbugs-annotations. Also the version number is updated to latest v4.9.1. Maven indicates the artifact has been moved as expressed in this change https://mvnrepository.com/artifact/com.google.code.findbugs/jsr305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the findbugs plugin.
Findbugs is superseded by SpotBugs. This is a dead build phase dependency. Spotbugs forked the dead findbugs. Even findbugs says to use spotbugs, which we already do. Before this change we are checking twice, once with a decade out of date version (findbugs).
See in the pom we are using the same settings on spotbugs (plus some additional suppressions for newer checks).
See https://github.com/findbugsproject/findbugs