-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable disable otp #256
Enable disable otp #256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 12 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @SKairinos)
backend/api/signals/user.py
line 15 at r3 (raw file):
from django.db.models.signals import post_save, pre_save from django.dispatch import receiver import pyotp
Are these imports organised?
backend/api/tests/signals/test_user.py
line 18 at r3 (raw file):
last_name="Doe", )
Spaces
backend/api/tests/signals/test_user.py
line 20 at r3 (raw file):
profile = UserProfile.objects.create(user=user)
Spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SKairinos)
This change is