Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] Inventory: cluster picking #11753

Closed
wants to merge 1 commit into from
Closed

[IMP] Inventory: cluster picking #11753

wants to merge 1 commit into from

Conversation

jero-odoo
Copy link
Contributor

Docs task:https://www.odoo.com/mail/view?model=project.task&res_id=4466703&access_token=e02873b9-458f-42b3-b3e1-e1b9613116a1

Updated in response to SME feedback. Updated images and content for 18

@jero-odoo jero-odoo added the 2 label Jan 14, 2025
@jero-odoo jero-odoo self-assigned this Jan 14, 2025
@robodoo
Copy link
Collaborator

robodoo commented Jan 14, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team January 14, 2025 19:58
@jero-odoo
Copy link
Contributor Author

hey @dikd-odoo this is ready for peer review. Thank you!

dikd-odoo
dikd-odoo approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@dikd-odoo dikd-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo great job on this update! The flow worked perfectly for me, so my edits were mainly optional and focused on user readability. Once you've taken a look at the suggestions, feel free to move this to final review. Thank you!

content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/cluster.rst Outdated Show resolved Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/cluster.rst Outdated Show resolved Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/cluster.rst Outdated Show resolved Hide resolved
@jero-odoo jero-odoo force-pushed the 18.0-cluster-picking-jero branch from 1b7310e to 10587c7 Compare January 15, 2025 18:50
@jero-odoo
Copy link
Contributor Author

Thank you Dina!
@Felicious this is ready for final review. Thanks!

@jero-odoo jero-odoo requested a review from a team January 15, 2025 19:02
Felicious
Felicious requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo !

took a more critical approach since I originally wrote this doc and left a few comments to make it more concise and focused on Inventory workflows. These are just suggestions, so feel free to decide what works best! 😊

The only thing I need your help with is updating the barcode section for version 18, as the navigational instructions differ slightly from 17. I’ve included the details in a comment. Once you’ve updated that, tag me again—I’ll be happy to do another quick review!

content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/cluster.rst Show resolved Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/cluster.rst Show resolved Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/cluster.rst Show resolved Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/cluster.rst Show resolved Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/cluster.rst Outdated Show resolved Hide resolved
@jero-odoo jero-odoo force-pushed the 18.0-cluster-picking-jero branch from 10587c7 to 3ee7014 Compare January 23, 2025 17:25
@jero-odoo jero-odoo requested a review from Felicious January 23, 2025 17:38
Felicious
Felicious approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing everything! @jero-odoo

@jero-odoo
Copy link
Contributor Author

Thank you!
@samueljlieber this is ready for tech review.

@jero-odoo jero-odoo requested a review from a team January 23, 2025 18:44
samueljlieber
samueljlieber approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @jero-odoo! Nice work!
..
@robodoo r+

@robodoo robodoo closed this in c4e0f35 Jan 23, 2025
This was referenced Jan 23, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dikd-odoo dikd-odoo dikd-odoo approved these changes

@samueljlieber samueljlieber samueljlieber approved these changes

@Felicious Felicious Felicious approved these changes

Assignees

@jero-odoo jero-odoo

Labels
2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jero-odoo @robodoo @Felicious @samueljlieber @dikd-odoo