-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] Inventory: wave transfers 18 #11761
Conversation
0dcc905
to
a2bf044
Compare
Hey @hojo-odoo this is ready for review. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jero-odoo,
Nice job on this PR! It's ready for final review once you take a look at my comments.
Thanks,
John
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/wave.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/wave.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/wave.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/wave.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/wave.rst
Outdated
Show resolved
Hide resolved
b22571d
to
9b14acc
Compare
Thanks hojo! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing update, @jero-odoo!
The whole document flowed well, was to-the-point, and contained all the relevant information about waves. Approving with very minimal comments 😊
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/wave.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/wave.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/wave.rst
Show resolved
Hide resolved
9b14acc
to
4d16672
Compare
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jero-odoo, really great work on this overhaul! I am approving with two quick comments, I believe the (awesome) example needs an adjustment. Thank you for your work!
.....
@robodoo delegate=jero-odoo
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/wave.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/wave.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: hojo-odoo <[email protected]> Co-authored-by: Sam Lieber (sali) <[email protected]>
ff40d6b
to
92df58d
Compare
@robodoo r+ |
Significantly rewriting this doc to reflect changes in 18 and incorporate feedback from SME.
Docs task: https://www.odoo.com/mail/view?model=project.task&res_id=4466012&access_token=d7909917-719d-4cbd-85ae-d539ed2dbe83