Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Inventory: wave transfers 18 #11761

Closed
wants to merge 1 commit into from
Closed

Conversation

jero-odoo
Copy link
Contributor

@jero-odoo jero-odoo commented Jan 15, 2025

Significantly rewriting this doc to reflect changes in 18 and incorporate feedback from SME.

Docs task: https://www.odoo.com/mail/view?model=project.task&res_id=4466012&access_token=d7909917-719d-4cbd-85ae-d539ed2dbe83

@jero-odoo jero-odoo self-assigned this Jan 15, 2025
@robodoo
Copy link
Collaborator

robodoo commented Jan 15, 2025

Pull request status dashboard

@jero-odoo jero-odoo force-pushed the 18.0-wave-transfers-jero branch 2 times, most recently from 0dcc905 to a2bf044 Compare January 22, 2025 18:31
@jero-odoo jero-odoo marked this pull request as ready for review January 22, 2025 18:31
@C3POdoo C3POdoo requested a review from a team January 22, 2025 18:33
@jero-odoo
Copy link
Contributor Author

Hey @hojo-odoo this is ready for review. Thank you!

Copy link
Contributor

@hojo-odoo hojo-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jero-odoo,

Nice job on this PR! It's ready for final review once you take a look at my comments.

Thanks,
John

@jero-odoo jero-odoo force-pushed the 18.0-wave-transfers-jero branch from b22571d to 9b14acc Compare January 23, 2025 15:32
@jero-odoo
Copy link
Contributor Author

Thanks hojo!
@Felicious this is ready for final review. Thanks!

@jero-odoo jero-odoo requested a review from a team January 23, 2025 16:25
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing update, @jero-odoo!
The whole document flowed well, was to-the-point, and contained all the relevant information about waves. Approving with very minimal comments 😊

@jero-odoo jero-odoo force-pushed the 18.0-wave-transfers-jero branch from 9b14acc to 4d16672 Compare January 23, 2025 19:12
@jero-odoo
Copy link
Contributor Author

Thank you!
@samueljlieber this is ready for tech review.

@jero-odoo jero-odoo requested a review from a team January 23, 2025 19:24
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo, really great work on this overhaul! I am approving with two quick comments, I believe the (awesome) example needs an adjustment. Thank you for your work!
.....
@robodoo delegate=jero-odoo

Co-authored-by: hojo-odoo <[email protected]>

Co-authored-by: Sam Lieber (sali) <[email protected]>
@jero-odoo jero-odoo force-pushed the 18.0-wave-transfers-jero branch from ff40d6b to 92df58d Compare January 24, 2025 12:27
@jero-odoo
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants