Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility function with tests to pad datetime digits and validate #586

Merged
merged 4 commits into from
Oct 10, 2018

Conversation

ibnesayeed
Copy link
Member

Pad datetime to make a 14-digit string and optionally validate it as per #301.

@ibnesayeed ibnesayeed requested a review from machawk1 October 10, 2018 15:59
@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #586 into master will increase coverage by 0.78%.
The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
+ Coverage    23.6%   24.38%   +0.78%     
==========================================
  Files           6        6              
  Lines        1199     1218      +19     
  Branches      179      181       +2     
==========================================
+ Hits          283      297      +14     
- Misses        895      900       +5     
  Partials       21       21
Impacted Files Coverage Δ
ipwb/replay.py 13.95% <0%> (-0.11%) ⬇️
ipwb/util.py 34.5% <100%> (+4.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a97362c...2a5e697. Read the comment docs.

Copy link
Member

@machawk1 machawk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants