Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling #2636

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Error handling #2636

merged 1 commit into from
Feb 16, 2025

Conversation

corrideat
Copy link
Member

Closes #2624

@corrideat corrideat requested a review from taoeffect February 16, 2025 21:19
@corrideat corrideat self-assigned this Feb 16, 2025
@cypress Cypress
Copy link

cypress bot commented Feb 16, 2025 •
edited
Loading

group-income    Run #3983

Run Properties:  status check passed Passed #3983  •  git commit 75f6eb17f1 ℹ️: Merge 8a1db50a8e898dee15535335e871dadc4dffc384 into 2c25e3a45d88c47acc5021f60a5b...
Project group-income
Branch Review 2624-heisenbug-local-test-failure-in-group-chatspec-failed-to-join-general
Run status status check passed Passed #3983
Run duration 11m 01s
Commit git commit 75f6eb17f1 ℹ️: Merge 8a1db50a8e898dee15535335e871dadc4dffc384 into 2c25e3a45d88c47acc5021f60a5b...
Committer Ricardo Iván Vieitez Parra
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 114
View all changes introduced in this branch ↗︎

taoeffect
taoeffect requested changes Feb 16, 2025
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @corrideat! Minor formatting change request.

@corrideat corrideat force-pushed the 2624-heisenbug-local-test-failure-in-group-chatspec-failed-to-join-general branch from 8a1db50 to 5e8dad2 Compare February 16, 2025 22:16
@corrideat corrideat force-pushed the 2624-heisenbug-local-test-failure-in-group-chatspec-failed-to-join-general branch from 5e8dad2 to 747885a Compare February 16, 2025 22:17
taoeffect
taoeffect approved these changes Feb 16, 2025
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@taoeffect taoeffect merged commit defcec2 into master Feb 16, 2025
3 of 4 checks passed
@taoeffect taoeffect deleted the 2624-heisenbug-local-test-failure-in-group-chatspec-failed-to-join-general branch February 16, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoeffect taoeffect taoeffect approved these changes

Assignees

@corrideat corrideat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Heisenbug: Local test failure in group-chat.spec: failed to join #general
2 participants
@corrideat @taoeffect