Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin poetry version==1.8.5 #409

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

ParthSareen
Copy link
Contributor

@ParthSareen ParthSareen commented Jan 6, 2025

Test runner currently installs poetry 2.0.0 which introduces many breaking changes
Tracking in #410

image

@ParthSareen ParthSareen requested a review from mxyng January 6, 2025 19:19
@mxyng
Copy link
Collaborator

mxyng commented Jan 6, 2025

Instead of pinning, the project should be updated to be compatible with 2.0. It brings in positive changes with the breaking changes being fairly minor

@ParthSareen
Copy link
Contributor Author

ParthSareen commented Jan 6, 2025

@mxyng cool if that's a follow up? Want to get #408 and #398 in first. Blocked on this right now

@ParthSareen ParthSareen changed the title pin poetry version==1.8.5 chore: pin poetry version==1.8.5 Jan 7, 2025
@ParthSareen ParthSareen merged commit 34dc5df into parth/image-type-generate Jan 7, 2025
6 checks passed
@ParthSareen ParthSareen deleted the parth/pin-poetry-version branch January 7, 2025 01:58
ParthSareen added a commit that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants