test: aarch64: Skip Jit uni reorder if 4d matrix and zero point is defined #2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzarukin
reviewed
Nov 7, 2024
src/cpu/aarch64/jit_uni_reorder.cpp
Outdated
| bool has_zero_point | ||
| = !_pd->attr()->zero_points_.has_default_values(DNNL_ARG_FROM) | ||
| || !_pd->attr()->zero_points_.has_default_values(DNNL_ARG_TO); | ||
| if (src_md->ndims == 4 && has_zero_point) { return status::unimplemented; } |
There was a problem hiding this comment.
Since this implementation is a copy-paste of existing one for x64, I suggest moving the check either into prb_init or into tr::kernel_t::desc_init.
As for the check itself, is it only ndims=4? Or any ndims is affected by this limitation?
If the latter, then existing testing coverage should be enough to trigger the error and probably might not be needed.
There was a problem hiding this comment.
Thank you for the review, I have moved the check to prb_init.
As far as I can tell, the issue seems to be only ndims=4. I have run test_benchdnn_modeC_reorder_ci_cpu which passes so I would assume that the other ndims are okay
github-actions
bot
added
the
platform:cpu-aarch64
Ryo-not-rio
changed the title
Ryo-not-rio
force-pushed
the
fix-reorder
branch
from
77a5134
to
f267040
Compare
…fined Change-Id: I837a8f66d8e8f6afce8e944416db96987e95abac
Ryo-not-rio
force-pushed
the
fix-reorder
branch
from
f267040
to
46bea4a
Compare
Ryo-not-rio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jit:uni reorders for certain 4d matrices are returning incorrect results when the src zero point != 0. A guard has been added to skip jit uni reorders for any 4d matrices where src zero point != 0 so the simple:any implementation will be used. A new testcase has also been added to benchdnn.
Reproduction:
General
make testandmake test_benchdnn_*) pass locally for each commit?Bug fixes