Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python data loading script for neuropixels 1.0e headstage workflow #135

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jonnew
Copy link
Member

@jonnew jonnew commented Oct 29, 2024

- Modified example workflow a bit to facilitate this. Namely, timestamps
in files names were replaced with file counts because the headstage's
design means that data streams start at signficantly different times
@jonnew jonnew requested a review from cjsha October 29, 2024 21:47
Copy link
Member

@cjsha cjsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timestamps in files names were replaced with file counts because the headstage's design means that data streams start at signficantly different times

That's fine. ContextTask is timestamped after configuring the headstage. That should be sufficient for recording a software timestamp of when acquisition started. Do you think this is a standard we should try maintaining through the docs?

I didn't have data to recreate these plots. I trust it looks fine so I'll approve, but I can also acquire some or find your data to look at the plots myself if you want me to do that before merging.

@jonnew
Copy link
Member Author

jonnew commented Oct 30, 2024

Actually kinda do, but I dont care enough to make a big deal out of it.

Timestamps are the best for filenames. But they become extremely annoying if there are bunch of files for a single session that get created at different times and therefore have different suffixes. This is going to be common with this library, so we should stay away from them.

It also indicates we need a more unified recording operator, but this is already on the TODO.

@jonnew jonnew changed the title Add python data loading script for neuropixles 1.0e headstage workflow Add python data loading script for neuropixels 1.0e headstage workflow Oct 30, 2024
@jonnew
Copy link
Member Author

jonnew commented Oct 30, 2024

Note that this script still needs to be inserted into the docs for this merge to be complete.

Copy link
Member

@cjsha cjsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I integrated the np1hs loading script identically as the breakout loading script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add python load scripts to examples in the Hardware Guide
2 participants