feat!: use sdk-maintained state, require 1.12 #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned aepfli, beeme1mr, Kavindu-Dodan, laliconfigcat, liran2000, markphelps, sighphyre, thisthat, thiyagu06 and thomaspoignant
toddbaert
force-pushed
the
update-sdk
branch
2 times, most recently
from
c417290
to
83db67f
Compare
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
update-sdk
branch
from
83db67f
to
9ca7904
Compare
toddbaert
requested review from
aepfli,
liran2000,
UtkarshSharma2612,
thiyagu06,
thomaspoignant,
sighphyre,
laliconfigcat,
markphelps,
beeme1mr and
thisthat
Signed-off-by: Todd Baert <[email protected]>
liran2000
approved these changes
Sep 24, 2024
aepfli
approved these changes
Sep 24, 2024
beeme1mr
approved these changes
Sep 24, 2024
UtkarshSharma2612
approved these changes
Sep 24, 2024
Kavindu-Dodan
approved these changes
Sep 24, 2024
|
@thomaspoignant do you have any concerns with this? |
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
ProviderStatefrom providers - the SDK now keeps track of this so providers do not have toNothing here is breaking for consumers, it's a transparent change with the exception they will have to update their SDK version.
see: open-feature/java-sdk#1096