Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

survey: smoother submit dailog (fixes #5352) #5358

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

survey: smoother submit dailog (fixes #5352) #5358

wants to merge 2 commits into from

Conversation

pavi38
Copy link
Member

@pavi38 pavi38 commented Feb 26, 2025

fixes #5352

Screen.Recording.2025-02-26.at.1.23.35.PM.mov

Okuro3499
Okuro3499 requested changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavi38 I think the dialog should only be dismissable by clicking the finish button. user might mistakenly click the screen but be confused what happened

@pavi38 pavi38 requested a review from Okuro3499 February 27, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitk huitk huitk approved these changes

@deeppp15 deeppp15 deeppp15 approved these changes

@Okuro3499 Okuro3499 Awaiting requested review from Okuro3499

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
changes requested peer review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

user not able to finish survey
4 participants
@pavi38 @huitk @Okuro3499 @deeppp15