Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update androidplugin to v8.8.0 #737

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 9, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.android.application (source) 8.7.3 -> 8.8.0 age adoption passing confidence
com.android.tools.build:gradle (source) 8.7.3 -> 8.8.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner January 9, 2025 18:34
@breedx-splk
Copy link
Contributor

The build failure is interesting:

/opentelemetry-android/instrumentation/slowrendering/src/main/java/io/opentelemetry/android/instrumentation/slowrendering/SlowRenderingInstrumentation.java:46: Error: Unnecessary; Build.VERSION.SDK_INT < Build.VERSION_CODES.N is never true here [ObsoleteSdkInt]
        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.N) {
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

   Explanation for issues of type "ObsoleteSdkInt":
   This check flags version checks that are not necessary, because the
   minSdkVersion (or surrounding known API level) is already at least as high
   as the version checked for.

   Similarly, it also looks for resources in -vNN folders, such as values-v14
   where the version qualifier is less than or equal to the minSdkVersion,
   where the contents should be merged into the best folder.

It looks like the recent changes to SImpleNetworkDetector in #736 set up this version check, which is apparently moot with this new version of AGP. Does that also mean that this also increases our min api version? Are we ok with that?

@breedx-splk
Copy link
Contributor

We decided to skip this version for now based on the above errors. Will pick the next one up which should contain a bug fix for this linter issue.
https://issuetracker.google.com/issues/373506498?hl=ko&pli=1

Copy link
Contributor Author

renovate bot commented Jan 21, 2025

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (8.8.0). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/androidplugin branch January 21, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant