Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for MetricTypeSum #37156

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: add support for MetricTypeSum #37156

wants to merge 5 commits into from
+169 −10

Conversation

perebaj
Copy link
Contributor

@perebaj perebaj commented Jan 12, 2025

Description

Prometheus translation rw2 add support for MetricTypeSum.

The current work was inspired by #36353

Link to tracking issue #33661

@dashpole
Copy link
Contributor

Error: prometheusremotewrite/metrics_to_prw_v2.go:118:88: (*prometheusConverterV2).addSample - result 0 (*github.com/prometheus/prometheus/prompb/io/prometheus/write/v2.TimeSeries) is never used (unparam)
func (c *prometheusConverterV2) addSample(sample *writev2.Sample, lbls []prompb.Label) *writev2.TimeSeries {

dashpole
dashpole approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after lint errors are fixed

pkg/translator/prometheusremotewrite/number_data_points_v2.go Show resolved Hide resolved
@perebaj
Copy link
Contributor Author

perebaj commented Jan 18, 2025 •
edited
Loading

I’m encountering inconsistent behavior with the TestFromMetricsV2 test case. It sometimes passes but fails at other times, even though I haven’t made any changes related to its functionality. I’m trying to understand what’s causing this issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@ArthurSens ArthurSens Awaiting requested review from ArthurSens

@bertysentry bertysentry Awaiting requested review from bertysentry

Assignees
No one assigned
Labels
pkg/translator/prometheus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perebaj @dashpole