Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elasticsearchexporter] Consistently store the structured body of logs and events in otel mode #37387

Merged
merged 6 commits into from
Jan 24, 2025

Conversation

felixbarny
Copy link
Contributor

@felixbarny felixbarny commented Jan 21, 2025

The OTel community has reached a consensus that all structured data for events defined by semantic conventions should be stored in attributes (open-telemetry/semantic-conventions#1651 (comment)). The body for events may contain opaque/external data, which sounds like a job for the flattened field type.

Therefore, it no longer makes sense to map the body for logs and events differently.

The corresponding Elasticsearch mapping change has been merged already: elastic/elasticsearch#120547

@felixbarny felixbarny changed the title Consistently store the structured body of logs and events in otel mode [elasticsearchexporter] Consistently store the structured body of logs and events in otel mode Jan 21, 2025
Copy link
Contributor

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code change lgtm, thanks

.chloggen/elasticsearchexporter_log_body.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@felixbarny felixbarny marked this pull request as ready for review January 22, 2025 17:19
@felixbarny felixbarny requested a review from a team as a code owner January 22, 2025 17:19
@felixbarny
Copy link
Contributor Author

Hey @andrzej-stencel, I think this is ready to be merged. Could you have a look? 🙂

@andrzej-stencel andrzej-stencel merged commit b2dbcfb into open-telemetry:main Jan 24, 2025
164 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 24, 2025
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this pull request Jan 26, 2025
…s and events in `otel` mode (open-telemetry#37387)

The OTel community has reached a consensus that all structured data for
events defined by semantic conventions should be stored in attributes
(open-telemetry/semantic-conventions#1651 (comment)).
The body for events may contain opaque/external data, which sounds like
a job for the flattened field type.

Therefore, it no longer makes sense to map the body for logs and events
differently.

The corresponding Elasticsearch mapping change has been merged already:
elastic/elasticsearch#120547

---------

Co-authored-by: Carson Ip <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants