-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[elasticsearchexporter] Consistently store the structured body of logs and events in otel
mode
#37387
Merged
andrzej-stencel
merged 6 commits into
open-telemetry:main
from
felixbarny:es-log-event-body
Jan 24, 2025
Merged
[elasticsearchexporter] Consistently store the structured body of logs and events in otel
mode
#37387
andrzej-stencel
merged 6 commits into
open-telemetry:main
from
felixbarny:es-log-event-body
Jan 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixbarny
changed the title
Consistently store the structured body of logs and events in
[elasticsearchexporter] Consistently store the structured body of logs and events in Jan 21, 2025
otel
modeotel
mode
carsonip
reviewed
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code change lgtm, thanks
Co-authored-by: Carson Ip <[email protected]>
carsonip
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
carsonip
approved these changes
Jan 22, 2025
Hey @andrzej-stencel, I think this is ready to be merged. Could you have a look? 🙂 |
andrzej-stencel
approved these changes
Jan 24, 2025
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…s and events in `otel` mode (open-telemetry#37387) The OTel community has reached a consensus that all structured data for events defined by semantic conventions should be stored in attributes (open-telemetry/semantic-conventions#1651 (comment)). The body for events may contain opaque/external data, which sounds like a job for the flattened field type. Therefore, it no longer makes sense to map the body for logs and events differently. The corresponding Elasticsearch mapping change has been merged already: elastic/elasticsearch#120547 --------- Co-authored-by: Carson Ip <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OTel community has reached a consensus that all structured data for events defined by semantic conventions should be stored in attributes (open-telemetry/semantic-conventions#1651 (comment)). The body for events may contain opaque/external data, which sounds like a job for the flattened field type.
Therefore, it no longer makes sense to map the body for logs and events differently.
The corresponding Elasticsearch mapping change has been merged already: elastic/elasticsearch#120547