Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/mongodbreceiver] Added mongodb replica metrics and routing logic for multiple mongodb instances #37517

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[receiver/mongodbreceiver] Added mongodb replica metrics and routing logic for multiple mongodb instances #37517

wants to merge 5 commits into from

Conversation

chan-tim-sumo
Copy link
Contributor

Description

  • Added mongodb replica metrics and routing logic for multiple mongodb instances
  mongodb.repl_queries_per_sec
  mongodb.repl_inserts_per_sec
  mongodb.repl_commands_per_sec
  mongodb.repl_getmores_per_sec
  mongodb.repl_deletes_per_sec
  mongodb.repl_updates_per_sec

Link to tracking issue

Testing

Screenshot examples:

Documentation

@chan-tim-sumo chan-tim-sumo requested a review from a team as a code owner January 27, 2025 21:40
@github-actions github-actions bot requested a review from schmikei January 27, 2025 21:40
@chan-tim-sumo chan-tim-sumo force-pushed the mongodbReplicaMetrics branch 5 times, most recently from 0a323c6 to 6c79585 Compare January 27, 2025 22:06
@chan-tim-sumo chan-tim-sumo mentioned this pull request Jan 27, 2025
Open
@chan-tim-sumo
Copy link
Contributor Author

@schmikei can you take a look at this when you have time? was looking to make changes on this PR (if any comments) as well as 37227. thanks!

@chan-tim-sumo
Copy link
Contributor Author

@schmikei can you take a look at this PR? want to make sure this is good to go or any changes. Since I'm planning on making some changes #37227 as well!

@chan-tim-sumo
Copy link
Contributor Author

@schmikei bump :D

@chan-tim-sumo
Copy link
Contributor Author

@atoulme saw you're one of the assignees, would you be able to review this instead of Keith? thanks!

schmikei
schmikei approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@schmikei schmikei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay! Had to spend a minute to test this. Changes look good, other than a stylistic difference I think this change is good. Thank you for the contribution!

@github-actions github-actions bot mentioned this pull request Feb 25, 2025
Open
@chan-tim-sumo
Copy link
Contributor Author

@atoulme @fatsheep9146 when you have time, would appreciate the approval or merging! :)

atoulme
atoulme approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@schmikei schmikei schmikei approved these changes

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@atoulme atoulme

Labels
ready to merge Code review completed; ready to merge by maintainers receiver/mongodb waiting-for-code-owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chan-tim-sumo @atoulme @schmikei