-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/awss3exporter] Add canned_acl
as an input
#37953
base: main
Are you sure you want to change the base?
[exporter/awss3exporter] Add canned_acl
as an input
#37953
Conversation
Changes look good to me, but |
Need to build locally & test against an actual AWS bucket still, may also need to allow an empty string for the ACL. |
Validated against my own s3 bucket & behavior all seems correct. If ACLs are disabled at the bucket level, uploads work unless you specify an ACL. |
I am kicking the build, please hold off merging main, I have to kick the build off every time you do :) |
Description
Adds an additional input
canned_acl
to use when uploading S3 objects. Followed the same patterns as thestorage_class
option.Link to tracking issue
Fixes #37935
Testing
Updated config in all test files and added
testdata/config-s3_canned-acl.yaml
to validate input.Tested against personal S3 bucket, with various canned ACLs & with ACLs disabled at the bucket level
Documentation
Updated README to include new input with default value.