-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specs for empty telemetry envelopes. #622
base: main
Are you sure you want to change the base?
Add specs for empty telemetry envelopes. #622
Conversation
@djspinmonkey A mandatory pre-requisite for contributions to OTel is to sign the EasyCLA. Could you follow the link and make sure it is done.. (If contributing on behalf of an employer, you may want to consult them too) https://github.com/open-telemetry/community/blob/main/guides/contributor/CLA.md |
Thanks, I just filled that out! :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if a better place for this comment is in proto files, e.g. as a comment of the mesage:
message ResourceMetrics { |
In terms of the placement, I'm not sure about putting this in the metrics proto, since it's not specific to metrics - it would apply equally to logs or traces. It also doesn't really feel like a detail of the protobuff format to me, since it mostly applies (at least in my use case) to resources being processed that have already been hydrated into in-memory structs, rather than anything about the line format. That said, of course if that's where you think it should go, I'm happy to move it. Would you want it copied out into all three of metrics, logs, and traces protos if so? |
What we do currently is just copy/paste the same comment to all signals. Not great, I agree, but that's the current practice. I don't have a strong opinion on the placement. Let's see others think. |
Just following up here, are there any other changes folks would like to see before merging? I can copy it out into the three protobuff files, if that's the preference. |
Based on the discussion here, this PR adds some guidelines for handling empty telemetry envelopes. (Specifically, that they should generally be avoided and may be dropped.)
This is my first PR to the OTel spec, so please let me know if there's a better place to put this or I missed any steps of the process!