Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't normalize headers with "hyphen -> underscore" #3104

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Prev Previous commit
Next Next commit
Update instrumentation/opentelemetry-instrumentation-tornado/src/open…
…telemetry/instrumentation/tornado/__init__.py
emdneto authored Dec 20, 2024
commit 1fedc61b288bf5ff60b167e42408f5a5f577a853
Original file line number Diff line number Diff line change
@@ -139,7 +139,7 @@ def client_response_hook(span, future):
It is recommended that you should give the correct names of the headers to be captured in the environment variable.
Response header names captured in tornado are case insensitive. So, giving header name as ``CUStomHeader`` in environment variable will be able capture header with name ``customheader``.

The name of the added span attribute will follow the format ``http.response.header.<header_name>`` where ``<header_name>``being the normalized HTTP header name (lowercase).
The name of the added span attribute will follow the format ``http.response.header.<header_name>`` where ``<header_name>`` being the normalized HTTP header name (lowercase).
The value of the attribute will be single item list containing all the header values.

Example of the added span attribute,