Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try rename opentelemetry_sdk to opentelemetry-sdk #1776

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cijothomas
Copy link
Member

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@cijothomas cijothomas requested a review from a team May 15, 2024 18:31
@shaun-cox
Copy link
Contributor

This might have ramification on how or if this can be pushed to crates.io, I suspect. Should we consult with someone with more knowledge of the cargo publishing process to understand the consequences?

@cijothomas
Copy link
Member Author

This might have ramification on how or if this can be pushed to crates.io, I suspect. Should we consult with someone with more knowledge of the cargo publishing process to understand the consequences?

yes, I intend to do some research before attempting! Thanks.

@hdost
Copy link
Contributor

hdost commented Aug 20, 2024

We could consider posting a notice to https://rustsec.org/contributing.html about opentelemetry_sdk -> opentelemetry-sdk
Perhaps also we could try to write a wrapper for at least one version which just has opentelemetry_sdk wrapping opentelemetry-sdk directly.

@demurgos
Copy link
Contributor

Is there some related issue with the discussion about the rename? The naming consistency should be fixed indeed, but I'd like to read about why you picked to normalize using - (compared to normalizing the other crates to _). The reason why I'm asking is that both styles are present on crates.io. - feels a bit more popular, but many larger crates also use _ since it means that the crate name and import name match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants