[Logs] Initial draft to handle batch export into background thread #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomsonTan
changed the title
|
See https://github.com/open-telemetry/opentelemetry-rust/compare/main...lalitb:thread-runtime?expand=1 also to get some ideas about solving same/similar problems. |
ThomsonTan
changed the title
lalitb
reviewed
Oct 14, 2024
| // Either::Left((export_res, _)) => export_res, | ||
| // Either::Right((_, _)) => ExportResult::Err(LogError::ExportTimedOut(time_out)), | ||
| // } | ||
| ExportResult::Ok(()) |
There was a problem hiding this comment.
So, we are expecting export method to complete in a definite time-period, and we are not handling timeout outside of export method ? any reason why it is so ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2066
Changes
This is an early draft which implements the proposal mentioned in #2066, and looking for feedback.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes