Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Add test about batch processor with current_thread async runtime #2123

Merged
merged 8 commits into from
Sep 24, 2024

Conversation

ThomsonTan
Copy link
Contributor

Changes

Add test to reproduce the deadlock during shutdown of batch processor when configured with single thread async runtime. Related to issue #2066.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@ThomsonTan ThomsonTan requested a review from a team September 17, 2024 13:59
@ThomsonTan
Copy link
Contributor Author

Reproduced the hang in below iteration, ignore running the test in the latest iteration.

https://github.com/open-telemetry/opentelemetry-rust/actions/runs/10907111063/job/30269977617?pr=2123

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 15 lines in your changes missing coverage. Please review.

Project coverage is 78.9%. Comparing base (c93cf26) to head (7c7965c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/logs/log_processor.rs 70.5% 15 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2123     +/-   ##
=======================================
- Coverage   78.9%   78.9%   -0.1%     
=======================================
  Files        121     121             
  Lines      20780   20831     +51     
=======================================
+ Hits       16416   16453     +37     
- Misses      4364    4378     +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomsonTan ThomsonTan requested a review from a team as a code owner September 20, 2024 20:51
@cijothomas cijothomas merged commit b244673 into open-telemetry:main Sep 24, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants