Added AI Agent Semantic Convention #1739
Open
+340
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyliu513
force-pushed
the
agent-sc
branch
8 times, most recently
from
e814811 to
7b7efce
Compare
Signed-off-by: Guangya Liu <[email protected]>
gyliu513
force-pushed
the
agent-sc
branch
5 times, most recently
from
5628dbe to
9904399
Compare
lmolkova
approved these changes
Jan 22, 2025
gyliu513
commented
Jan 22, 2025
karthikscale3
approved these changes
Jan 23, 2025
TaoChenOSU
reviewed
Jan 23, 2025
TaoChenOSU
reviewed
Jan 23, 2025
TaoChenOSU
reviewed
Jan 23, 2025
TaoChenOSU
reviewed
Jan 23, 2025
samuelcolvin
suggested changes
Jan 24, 2025
docs/attributes-registry/gen-ai.md
Outdated
| @@ -52,14 +58,18 @@ attribute may help identify the actual system in use for `openai`. | |||
| For custom model, a custom friendly name SHOULD be used. | |||
| If none of these options apply, the `gen_ai.system` SHOULD be set to `_OTHER`. | |||
|
|
|||
| **[4] `gen_ai.tool.type`:** Extension: A tool executed on the agent-side to directly call external APIs, bridging the gap between the agent and real-world systems. Function: A tool executed on the client-side, where the agent generates parameters for a predefined function, and the client executes the logic. Datastore: A tool used by the agent to access and query structured or unstructured external data for retrieval-augmented tasks or knowledge updates. | |||
There was a problem hiding this comment.
I'm not clear on the what you mean by "agent-side" and "client-side". The term "agent-side" isn't used elsewhere in this document or the repo at large. I think they need defining better.
More generally, I don't think your distinction between a function and a tool is how most people would understand them.
That said, I don't have a good definition for the distinction.
There was a problem hiding this comment.
My suggestion would be:
- tools are passed to the model - tools the model can call
- functions are invoked when a tool is called.
Most tools are functions, but not all.
There was a problem hiding this comment.
okay, so I see now that "agent-side" is used in the google whitepaper, but again without a definition 😞 .
There was a problem hiding this comment.
ok, I will add some definition as below:
- agent-side: Agent-side operations involve actions that are performed by the agent on the server or within the agent's controlled environment. This typically includes tasks like: Executing API calls directly; Managing data through Extensions that interact with external APIs and services etc.
- client-side: Client-side operations are actions taken on the user's end or within the client application. This includes: Executing functions that are generated by the agent but run locally. This is particularly useful in scenarios where immediate API interaction by the agent is impractical or restricted by security policies; Processing and handling function outputs, where the logic and execution of calling external APIs are handled by the client-side application, giving developers control over the data flow and reducing the load or dependency on the agent.
3 tasks
|
Hey all, thanks for the comments, we have several follow ups for this PR, I will create related PRs soon to fix. |
TaoChenOSU
approved these changes
Jan 29, 2025
lmolkova
reviewed
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1732
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]