-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes: How to populate resource attributes based on attributes, labels and transformation #1756
base: main
Are you sure you want to change the base?
Kubernetes: How to populate resource attributes based on attributes, labels and transformation #1756
Changes from all commits
d883b85
0cab634
c25bef3
d29a822
3bdfb50
3d15651
f561458
d4e7588
154d93f
3652308
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
change_type: enhancement | ||
|
||
component: k8s | ||
|
||
note: How to populate resource attributes based on attributes, labels and transformation | ||
|
||
issues: [236] | ||
|
||
subtext: |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -354,3 +354,11 @@ A CronJob creates Jobs on a repeating schedule. | |
<!-- endsemconv --> | ||
|
||
[DocumentStatus]: https://opentelemetry.io/docs/specs/otel/document-status | ||
|
||
## Specify resource attributes using Kubernetes annotations | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if this should be an OTEP (or non-normative guide) instead. Also I wonder if that could be part of the @open-telemetry/specs-semconv-approvers thoughts? |
||
|
||
All annotations with the `resource.opentelemetry.io/` prefix should be translated into the corresponding resource | ||
attributes. | ||
|
||
For example, the annotation `resource.opentelemetry.io/service.name` should be translated into the `service.name` | ||
attribute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is currently applicable to auto-instrumentation with operator, I think we should clarify that these are the guidelines suggested by conventions and adopted in operator. So maybe change the heading to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point
maybe "should" is better?