avb_verify: Remove KVDB related verfications #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JianyuWang0623
requested review from
xiaoxiang781216 and
GUIDINGLI
as code owners
JianyuWang0623
force-pushed
the
br_wjy_system_ota_avb_rm_kvdb_related_250212_openvela
branch
2 times, most recently
from
3435088 to
03af071
Compare
It`s unsafe to store values to KVDB.
1. The options "-c" was removed, please use "-U"(upgrade verfication) instead.
Comparing rollback index to prevent duplicate installation
2. The parameters of INTERNAL used function `avb_verify` was updated:
-int avb_verify(const char* partition, const char* key, const char* suffix, AvbSlotVerifyFlags flags)
+int avb_verify(struct avb_params_t* params)
Test
dd if=/dev/random of=1MB_1.1 bs=1MB count=1
../tools/avb_sign.sh 1MB_1.1 0 -P $(pwd)/1MB -o --dynamic_partition_size -o "--rollback_index_location 1" -o "--rollback_index 1"
dd if=/dev/random of=1MB_1.2 bs=1MB count=1
../tools/avb_sign.sh 1MB_1.2 0 -P $(pwd)/1MB -o --dynamic_partition_size -o "--rollback_index_location 1" -o "--rollback_index 2"
./avb_verify -I 1MB_1.1
./avb_verify -I 1MB_1.2
./avb_verify -U 1MB_1.2 1MB_1.1 ../tools/keys/key.avb && echo PASSED || echo FAILED
./avb_verify -U 1MB_1.2 1MB_1.2 ../tools/keys/key.avb && echo PASSED || echo FAILED
./avb_verify -U 1MB_1.1 1MB_1.2 ../tools/keys/key.avb && echo FAILED || echo PASSED
rm -v 1MB_1.1 1MB_1.2
Signed-off-by: wangjianyu3 <[email protected]>
JianyuWang0623
force-pushed
the
br_wjy_system_ota_avb_rm_kvdb_related_250212_openvela
branch
from
03af071 to
c774428
Compare
xiaoxiang781216
approved these changes
Feb 13, 2025
|
@JianyuWang0623 ci fail. |
"Parse PR Description for Dependencies" failed, |
The inclusion of '$' in the body caused a parsing exception, which has been fixed |
xiaoxiang781216
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: Has NOT committed to gerrit yet
Summary
It`s unsafe to store values to KVDB.
The options "-c" was removed, please use "-U"(upgrade verfication) instead.
Comparing rollback index to prevent duplicate installation
The parameters of INTERNAL used function
avb_verifywas updated:-int avb_verify(const char* partition, const char* key, const char* suffix, AvbSlotVerifyFlags flags)
+int avb_verify(struct avb_params_t* params)
Impact
frameworks/system/ota/verify/avb_verify
Testing
Result