Request accept buttons into dropdown #16987
Open
+56
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellcp-work
reviewed
Nov 4, 2024
danidoni
force-pushed
the
request-accept-dropdown
branch
from
eb996d4
to
75b59e3
Compare
Now the buttons are inside a dropdown that the test has to click
danidoni
force-pushed
the
request-accept-dropdown
branch
from
5bac5df
to
6d61fb2
Compare
danidoni
force-pushed
the
request-accept-dropdown
branch
from
6d61fb2
to
ec2245d
Compare
danidoni
force-pushed
the
request-accept-dropdown
branch
2 times, most recently
from
95fe35a
to
5927305
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposal is about keeping separated all the different decision actions, but grouping the
accept requestones. Accepting request can be made like:Due to the fact that the forward can be submitted to multiple choices, they requires checkboxes to be visible and selectable. The forwarding destinations are shown as checkboxes above the buttons