Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: dockerfile #16

Merged
merged 4 commits into from
Feb 22, 2024
Merged

refactor: dockerfile #16

merged 4 commits into from
Feb 22, 2024

Conversation

chrisgacsal
Copy link
Contributor

@chrisgacsal chrisgacsal commented Feb 21, 2024 •
edited
Loading

Description

  • use alpine:3.19
  • pin clamav/freshclam version to the same as used in
    vmclarity-tools-base/vmclarity-cli images
  • update nginx configuration
  • fail docker build on database update error

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@chrisgacsal chrisgacsal requested a review from a team as a code owner February 21, 2024 22:02
@chrisgacsal chrisgacsal self-assigned this Feb 21, 2024
@chrisgacsal
refactor: dockerfile
6bb5c36 
* use alpine:3.19
* pin clamv/freshclam version to the same as used in
  vmclarrity-tools-base/vmclarity-cli images
* update nginx configuration
@chrisgacsal
fix: missing service dependency descriptor
23c7b80
lgecse
lgecse previously approved these changes Feb 22, 2024
View reviewed changes
akijakya
akijakya previously approved these changes Feb 22, 2024
View reviewed changes
@chrisgacsal chrisgacsal dismissed stale reviews from akijakya and lgecse via a40bc32 February 22, 2024 08:26
@chrisgacsal chrisgacsal force-pushed the refactor-dockerfile branch 2 times, most recently from 2c90488 to 39e2337 Compare February 22, 2024 10:55
@chrisgacsal chrisgacsal merged commit 6965c40 into main Feb 22, 2024
2 checks passed
@chrisgacsal chrisgacsal deleted the refactor-dockerfile branch February 22, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgecse lgecse lgecse approved these changes

@akijakya akijakya Awaiting requested review from akijakya

Assignees

@chrisgacsal chrisgacsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisgacsal @akijakya @lgecse