Merge pull request #1371 from opencomponents/dont-install-when-packaging

dont install when packaging at all

src/cli/commands.ts

@@ -107,12 +107,6 @@ export default {
           boolean: true,
           description: 'Create zipped file',
           default: false
-        },
-        useComponentDependencies: {
-          boolean: true,
-          description:
-            'Reuse already installed dependencies to save packaging time and network bandwidth',
-          default: false
         }
       },
       description: 'Create the packaged component ready to be published',

src/cli/domain/handle-dependencies/index.ts

@@ -9,7 +9,6 @@ import type { Logger } from '../../logger';
 import ensureCompilerIsDeclaredAsDevDependency from './ensure-compiler-is-declared-as-devDependency';
 import getCompiler from './get-compiler';
 import installMissingDependencies from './install-missing-dependencies';
-import linkMissingDependencies from './link-missing-dependencies';
 
 const getComponentPackageJson = (componentPath: string): Promise<Component> =>
   fs.readJson(path.join(componentPath, 'package.json'));
@@ -19,14 +18,14 @@ const union = (a: ReadonlyArray<string>, b: ReadonlyArray<string>) => [
 ];
 
 export default async function handleDependencies(options: {
+  install?: boolean;
   components: string[];
   logger: Logger;
-  useComponentDependencies?: boolean;
 }): Promise<{
   modules: string[];
   templates: Array<Template>;
 }> {
-  const { components, logger, useComponentDependencies } = options;
+  const { components, logger } = options;
 
   const dependencies: Record<string, string> = {};
   const addDependencies = (componentDependencies?: Record<string, string>) => {
@@ -80,15 +79,9 @@ export default async function handleDependencies(options: {
     modules: union(coreModules, Object.keys(dependencies)).sort(),
     templates: Object.values(templates)
   };
-  if (useComponentDependencies) {
-    linkMissingDependencies({
-      componentPath: components[0],
-      dependencies,
-      logger
-    });
-    return result;
-  }
 
-  await installMissingDependencies({ dependencies, logger });
+  if (options.install) {
+    await installMissingDependencies({ dependencies, logger });
+  }
   return result;
 }

src/cli/facade/dev.ts

@@ -141,6 +141,7 @@ const dev = ({ local, logger }: { logger: Logger; local: Local }) =>
         logger.log(colors.green('├── ') + component);
       }
       const dependencies = await handleDependencies({
+        install: true,
         components,
         logger
       }).catch((err) => {

src/cli/facade/package.ts

@@ -10,11 +10,9 @@ const cliPackage = ({ local, logger }: { local: Local; logger: Logger }) =>
   fromPromise(
     async (opts: {
       componentPath: string;
-      useComponentDependencies?: boolean;
       compress?: boolean;
     }): Promise<Component> => {
       const componentPath = opts.componentPath;
-      const useComponentDependencies = opts.useComponentDependencies;
       const packageDir = path.resolve(componentPath, '_package');
       const compressedPackagePath = path.resolve(
         componentPath,
@@ -25,8 +23,7 @@ const cliPackage = ({ local, logger }: { local: Local; logger: Logger }) =>
       try {
         await handleDependencies({
           components: [path.resolve(componentPath)],
-          logger,
-          useComponentDependencies
+          logger
         });
 
         const packageOptions = {