Switch to poetry #19
Switch to poetry #19
Conversation
|
Oops forgot to update GitHub workflows. Don't review yet |
| pip install flake8 pytest | ||
| pip install -e "./vcap[easy,tests]" | ||
| pip install -e "./vcap_utils[tests]" | ||
| working-directory: ./vcap_utils |
There was a problem hiding this comment.
This grabs the PyPI version of vcap. Undesirable, but now sure how to proceed
There was a problem hiding this comment.
Would it work to run something like poetry install ../vcap?
| pip install flake8 pytest | ||
| pip install -e "./vcap[easy,tests]" | ||
| pip install -e "./vcap_utils[tests]" | ||
| working-directory: ./vcap_utils |
There was a problem hiding this comment.
Would it work to run something like poetry install ../vcap?
| python3 -m twine upload dist/* | ||
| POETRY_HTTP_BASIC_PYPI_USERNAME: __token__ | ||
| POETRY_HTTP_BASIC_PYPI_PASSWORD: ${{ secrets.PYPI_PASSWORD }} | ||
| run: poetry publish |
There was a problem hiding this comment.
If you haven't already, would you mind testing this pipeline with Test PyPI to make sure all is well? To do that, you have to set these environment variables:
POETRY_REPOSITORIES_TESTPYPI_URL: https://test.pypi.org/legacy/
POETRY_HTTP_BASIC_TESTPYPI_USERNAME: __token__
POETRY_HTTP_BASIC_TESTPYPI_PASSWORD=${{ secrets.TEST_PYPI_PASSWORD }}
and then add --repository testpypi to the publish command. You'd also have to get rid of the rule saying this only runs on the master branch temporarily.
| @@ -7,48 +7,31 @@ on: | |||
| jobs: | |||
There was a problem hiding this comment.
It seems like this job is still set up to run for every commit on master, but I think that would make this CI fail unless we always bump the vcap and vcap_utils versions for every commit since PyPI doesn't let you overwrite versions. Should it instead run only when there's a git tag?
There was a problem hiding this comment.
poetry has a version command. So you can do poetry version minor and it bumps the version in the toml.
Is this something we could integrate into the CI?
No description provided.