Implementation of Global sampling based matting #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorkalov
reviewed
Oct 11, 2019
There was a problem hiding this comment.
The patch breaks build, please fix it:
/build/precommit-contrib_linux64/opencv_contrib/modules/ximgproc/test/test_globalmatting.cpp:16:7: error: 'class opencv_test::{anonymous}::CV_GlobalMattingTest' has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor]
class CV_GlobalMattingTest
^
/build/precommit-contrib_linux64/opencv_contrib/modules/ximgproc/test/test_globalmatting.cpp: In member function 'void opencv_test::{anonymous}::CV_GlobalMattingTest::runModel()':
/build/precommit-contrib_linux64/opencv_contrib/modules/ximgproc/test/test_globalmatting.cpp:38:5: error: 'ts' was not declared in this scope
ts->printf(cvtest::TS::LOG,"Test images not found!\n");
^
/build/precommit-contrib_linux64/opencv_contrib/modules/ximgproc/test/test_globalmatting.cpp:44:5: error: 'ts' was not declared in this scope
ts->printf(cvtest::TS::LOG,"Dimensions of trimap and the image are not the same");
^
/build/precommit-contrib_linux64/opencv_contrib/modules/ximgproc/test/test_globalmatting.cpp:53:5: error: 'ts' was not declared in this scope
ts->printf(cvtest::TS::LOG,"Could not find the alpha matte for the image\n");
^
/build/precommit-contrib_linux64/opencv_contrib/modules/ximgproc/test/test_globalmatting.cpp:60:5: error: 'ts' was not declared in this scope
ts->printf(cvtest::TS::LOG,"The dimensions of the output are not correct");
^
/build/precommit-contrib_linux64/opencv_contrib/modules/ximgproc/test/test_globalmatting.cpp: In member function 'virtual void opencv_test::{anonymous}::CV_GlobalMattingTest_accuracy_Test::Body()':
/build/precommit-contrib_linux64/opencv_contrib/modules/ximgproc/test/test_globalmatting.cpp:80:8: error: 'class opencv_test::{anonymous}::CV_GlobalMattingTest' has no member named 'safe_run'
test.safe_run();
^
cc1plus: some warnings being treated as errors
|
@Nerdyvedi Do you have any progress on the patch? |
|
@asmorkalov Just give me this weekend, I will fix this |
|
@asmorkalov Could you please take a look at what's wrong, I don't think the issue is with my code |
alalek
reviewed
Nov 19, 2019
| const std::string TRIMAP_FILENAME = "trimap/doll.png"; | ||
|
|
||
|
|
||
| void runModel() |
Nerdyvedi
force-pushed
the
globalMattingFinal
branch
from
9a7071b
to
0e20320
Compare
|
@alalek , Buildbot is giving a patch size error, Even though I have squashed my commits. Is it because I have commited 9 images for the tutorial |
PNG format is not very good for real-life content. Ignore size warning for now ("delete PNG" can't remove data from git history) |
|
@alalek I have made the changes you asked for, There is a patch size error, Could you let me know how to solve it? |
Add files via upload Add files via upload Add files via upload Update README.md Update and rename mattingClass.cpp to globalmatting.cpp Rename mattingClass.h to globalmatting.h Update and rename globalmatting.h to globalmatting.hpp Update globalmatting.cpp Add files via upload Update global_matting_sample.cpp Update test_global_matting.cpp Update globalmatting.cpp Update globalmatting.hpp Update globalmatting.hpp Update globalmatting.cpp Update globalmatting.cpp Update globalmatting.hpp Update globalmatting.hpp Update ximgproc.hpp Update ximgproc.hpp Update ximgproc.hpp Update CMakeLists.txt Update globalmatting.hpp Update globalmatting.hpp Update globalmatting.hpp Update globalmatting.hpp Update globalmatting.hpp Update globalmatting.cpp Update globalmatting.cpp Update test_global_matting.cpp Update test_global_matting.cpp Update test_global_matting.cpp Update global_matting_sample.cpp Update globalmatting.cpp Update globalmatting.hpp Removing trailing whitespaces Removing whitespaces Rename global_matting_sample.cpp to globalmatting.cpp Rename test_global_matting.cpp to test_globalmatting.cpp Update globalmatting.cpp Update globalmatting.cpp Update globalmatting.cpp Update globalmatting.cpp Update globalmatting.cpp Update test_globalmatting.cpp Update test_globalmatting.cpp Update test_globalmatting.cpp Update globalmatting.hpp Update globalmatting.cpp Update test_globalmatting.cpp Removing whitespaces Removed whitespaces Update test_globalmatting.cpp Update test_globalmatting.cpp Update test_globalmatting.cpp Update globalmatting.cpp Removing global structure from header file Added the global structure into cpp file Added license and removed extra header files Added License information Removed whitespaces Update globalmatting.cpp Create globalmatting.md Update globalmatting.md Update globalmatting.md Removed square function from the public header Added the square function to the source file Added license information and removed BaseTest Using cvtest::findDatafile Bringing y to outer loop and x in inner loop Added license information to sample Update test_globalmatting.cpp Removed trailing whitespaces Update README.md Update README.md Update globalmatting.md Not using BaseTest legacy code anymore Put all the testing code in the Test() Fixed buildbot errors Fixed syntactical errors Fixed whitespace errors Removing highgui dependency It is redundant for the module Removed highgui header file highgui module is not used in header files Using CV_CheckTypeEQ function Fixed buildbot errors Fixed whitespace errors Added __OPENCV_XIMGPROC prefix and _HPP___ suffix Removed unnecessary header files Using Scalar::all(0) instead of (uchar)0 Replacing Scalar::all(0) with cv::Scalar::all(0) Replacing Scalar::all(0) with (uchar)0 Using opencv's random function Removed whitespace errors Added images used in tutorials No external links on embedded images are now used Fixed image path error Removing png input Removing png input Removing input png Removing trimap png Removing trimap png Removing trimap png Uploading jpg files Update globalmatting.md Bringing y to outer loop Using normL2Sqr function
- moved out implementation details from public API - don't use cv:: - more checks - updated test
|
I rebased patch and cleanup code according OpenCV coding style guide. Added reference test data check into test shows that result is unstable. Please take a look. P.S. Fetch code from your fork directly, don't try to "rebase" or "merge". |
alalek
reviewed
Dec 31, 2019
| Point p(x, y); | ||
|
|
||
| samples[y][x].fi = rand() % foregroundBoundary.size(); | ||
| samples[y][x].bj = rand() % backgroundBoundary.size(); |
There was a problem hiding this comment.
Avoid using rand() anywhere.
It is not stable and sometimes it is not thread safe. We need reproducible results for automated tests.
Consider using of OpenCV's thread local theRNG() implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with extra: opencv/opencv_extra#682
This is the C++ implementation of Global sampling based method for alpha matting