glm transition - deprecations implicit conversions, remove implicit conversions from the core. #5594

bakercp · 2017-05-05T02:18:21Z

This is related to #5440, the effort to ease the glm transition.

I looked into deprecating entire classes (e.g. ofVec2f, etc), but it created a huge mess of deprecation warnings, so instead I opted to just add deprecation warnings in those places where glm/of conversions were happening implicitly.

I also discovered a few remaining places where ofVec* was being used explicitly and a few interesting places in ofNode where when adding an glm::vec3 + glm::vec4 resulted in an intermediate conversion to ofVec3f.

Currently this shouldn't produce any deprecations warnings from the core itself, but only with non-conforming examples and user code that still employs ofVec*.

bakercp · 2017-05-05T02:19:00Z

libs/openFrameworks/3d/ofNode.cpp

@@ -597,7 +597,7 @@ void ofNode::orbitDeg(float longitude, float latitude, float radius, const glm::
 	p = q * p;							   // rotate p on unit sphere based on quaternion
 	p = p * radius;						   // scale p by radius from its position on unit sphere

-	setGlobalPosition(centerPoint + p);
+	setGlobalPosition(centerPoint + p.xyz());


Without this, an intermediate ofVec3f conversion was being used.

bakercp · 2017-05-05T02:19:08Z

libs/openFrameworks/3d/ofNode.cpp

@@ -132,9 +132,9 @@ void ofNode::setParent(ofNode& parent, bool bMaintainGlobalTransform) {
 		clearParent(bMaintainGlobalTransform);
 	}
 	if(bMaintainGlobalTransform) {
-		auto postParentPosition = position - parent.getGlobalPosition();
+		auto postParentPosition = position.get() - parent.getGlobalPosition();


Without this, an intermediate ofVec3f conversion was being used.

bakercp · 2017-05-05T02:19:26Z

libs/openFrameworks/app/ofAppGLFWWindow.cpp

@@ -756,7 +756,7 @@ void ofAppGLFWWindow::setFullscreen(bool fullscreen){
        GLFWmonitor** monitors = glfwGetMonitors(&monitorCount);

 		int currentMonitor = getCurrentMonitor();
-		ofVec3f screenSize = getScreenSize();


Leftover ofVec.

bakercp · 2017-05-05T02:19:39Z

libs/openFrameworks/graphics/ofGraphics.cpp

@@ -1138,14 +1138,14 @@ void ofVertices( const vector <glm::vec2> & polyPoints ){
 //----------------------------------------------------------
 void ofVertices( const vector <ofVec3f> & polyPoints ){
 	for( const auto & p: polyPoints ){
-		ofGetCurrentRenderer()->getPath().lineTo(p);
+		ofGetCurrentRenderer()->getPath().lineTo(glm::vec3(p.x, p.y, p.z));


Use explicit conversions throughout.

bakercp · 2017-05-05T02:20:09Z

libs/openFrameworks/math/ofMatrix3x3.h

@@ -42,11 +42,11 @@ class ofMatrix3x3 {
 				float _g=0.0, float _h=0.0, float _i=0.0 );


-	ofMatrix3x3( const glm::mat3 & mat) {
+	OF_DEPRECATED_MSG("Use glm::mat3.", ofMatrix3x3( const glm::mat3 & mat)) {


Encourage the use of glm::* without breaking things.

bakercp · 2017-05-05T02:20:33Z

libs/openFrameworks/math/ofVectorMath.h

@@ -243,88 +243,88 @@ namespace glm {

 //--------------------------------------------------------------
 inline glm::vec3 operator+(const glm::vec3 & v1, const ofVec3f & v2){
-	return v1 + glm::vec3(v2);
+	return v1 + glm::vec3(v2.x, v2.y, v2.z);


Remove implicit conversions.

Fix typos

Switched from string to filesystem::path for some utility functions.

+ ofMatrixStack depends on ofFbo, although it really only calls methods of ofFbo's base class, ofBaseDraws - essentially queries onto the RenderSurface's geometry. The proposed changes update ofMatrixStack to require just an ofBaseDraws compatible object to be passed as target render surface. This allows other renderers, such as the vulkan renderer, to use this object, without having access to ofFbo.

…shes).

…ix_stack_from_fbo remove dependency ofMatrixStack<->ofFbo

…ists Making sure json file exists before reading from it

…tch-1 Update README.md

…code8 Fix warnings in Xcode 8.

Fix copy paste error in comment

…erial Fix warning about unused function.

ofSerial: fix port name vs. path parsing on Windows

This removes deprecation warnings.

Update apothecary submodule with GLM update, etc.

…tch-1 Download correct RPI libs when arch is not spec'd

…orks into glm-deprecations

arturoc · 2017-05-20T21:44:38Z

i'm not so sure about this, people are going to use ofVec for a long while and although i see how it's really useful for catching where you are still using ofVec i think it can also be a problem cause a lot of addons are using ofVec and most people are not going to port them right away (if at all) so this is going to throw a million warnings in most projects

even most examples still use ofVec right now

perhaps there could be a flag to enable this? this is only header code so you can just do:

#define OF_DEPRECATE_OFVEC
#include "ofMain.h"

or define that in the project files, makefiles... while compiling the core, examples... so we can catch usage of ofVec

bakercp · 2017-05-20T23:39:41Z

Well, the intention was to "encourage" people to migrate via deprecation warnings since we are deprecating ofVec. Deprecation warnings are indeed annoying, but that is their purpose no? Keeping oF in limbo for more than a CV release or two is going to be a bit of a maintenance pain. Most people probably won't read the documentation, but the will see the warnings :)

bakercp · 2017-09-07T14:53:23Z

@arturoc Any thoughts on this?

mattfelsen and others added 5 commits February 28, 2017 12:49

ofSerial: fix port name vs. path parsing on Windows

e6a9049

Fix warnings in Xcode 8.

6e0a305

Fix warning about unused function.

a2119d4

Deprecate implicit glm::* ofMath classes.

7cab04f

Remove deprecated implicit vector / math conversions from the core.

7429244

bakercp commented May 5, 2017

View reviewed changes

bakercp and others added 19 commits May 4, 2017 22:20

Update README.md

b0b88c6

Fix typos

95f7639

Merge pull request openframeworks#5600 from hamoid/patch-2

4fc3947

Fix typos

Fix copy paste error in comment

a5587a6

Switched from string to filesystem::path for some utility functions.

f9780d3

Merge pull request openframeworks#5603 from Entropy/feature-fileutils

6947da8

Switched from string to filesystem::path for some utility functions.

Making sure json file exists before reading from it (otherwise it cra…

e12e051

…shes).

Merge pull request openframeworks#5608 from tgfrerer/disentangle_matr…

a5401f3

…ix_stack_from_fbo remove dependency ofMatrixStack<->ofFbo

Switched to using ofLoadJson.

a6adf47

Forgot to actually load the data :)

9ac4452

Merge pull request openframeworks#5609 from Entropy/hotfix-jsonfileex…

4523394

…ists Making sure json file exists before reading from it

Merge pull request openframeworks#5595 from openframeworks/bakercp-pa…

af6f0c6

…tch-1 Update README.md

Download correct RPI libs when arch is not spec'd

a179a80

Update apothecary submodule commit.

392bcf9

Merge pull request openframeworks#5575 from bakercp/fix-warnings-on-x…

95d31be

…code8 Fix warnings in Xcode 8.

Merge pull request openframeworks#5601 from hamoid/patch-3

c26e868

Fix copy paste error in comment

Merge pull request openframeworks#5586 from johnkingsley/fixwarning-s…

39fdbba

…erial Fix warning about unused function.

Merge pull request openframeworks#5466 from mattfelsen/serial-name-win

e3202a4

ofSerial: fix port name vs. path parsing on Windows

bakercp and others added 4 commits May 18, 2017 23:20

Define was deprecated/replaced with glm 0.9.8.0.

be2c3bb

This removes deprecation warnings.

Merge pull request openframeworks#5617 from bakercp/update-apothecary

3c4d8c5

Update apothecary submodule with GLM update, etc.

Merge pull request openframeworks#5616 from openframeworks/bakercp-pa…

3ae16bc

…tch-1 Download correct RPI libs when arch is not spec'd

Merge branch 'master' of https://github.com/openframeworks/openFramew…

a84b697

…orks into glm-deprecations

bakercp self-assigned this Oct 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

glm transition - deprecations implicit conversions, remove implicit conversions from the core. #5594

glm transition - deprecations implicit conversions, remove implicit conversions from the core. #5594

bakercp commented May 5, 2017

bakercp May 5, 2017

bakercp May 5, 2017

bakercp May 5, 2017

bakercp May 5, 2017

bakercp May 5, 2017

bakercp May 5, 2017

arturoc commented May 20, 2017

bakercp commented May 20, 2017

bakercp commented Sep 7, 2017

glm transition - deprecations implicit conversions, remove implicit conversions from the core. #5594

Are you sure you want to change the base?

glm transition - deprecations implicit conversions, remove implicit conversions from the core. #5594

Conversation

bakercp commented May 5, 2017

bakercp May 5, 2017

Choose a reason for hiding this comment

bakercp May 5, 2017

Choose a reason for hiding this comment

bakercp May 5, 2017

Choose a reason for hiding this comment

bakercp May 5, 2017

Choose a reason for hiding this comment

bakercp May 5, 2017

Choose a reason for hiding this comment

bakercp May 5, 2017

Choose a reason for hiding this comment

arturoc commented May 20, 2017

bakercp commented May 20, 2017

bakercp commented Sep 7, 2017