8317801: java/net/Socket/asyncClose/Race.java fails intermittently (aix) #21087
+72
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preClose() method internally calls the dup2() system call. If there is a dup2() call on a file descriptor on a thread while another thread is blocked in a read/write operation on the same file descriptor, then the dup2() call is known to hang. Currently, preClose() experiences a hang because we call dup2() before killing the reader/writer thread(s). The workaround is to first kill the reader/writer thread(s) and then do the preClose() sequence. This reordering in the different channel implementations resolves the problem.
JBS Issue : JDK-8317801
Progress
Issue
Contributors
<[email protected]>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21087/head:pull/21087
$ git checkout pull/21087
Update a local copy of the PR:
$ git checkout pull/21087
$ git pull https://git.openjdk.org/jdk.git pull/21087/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21087
View PR using the GUI difftool:
$ git pr show -t 21087
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21087.diff