Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317801: java/net/Socket/asyncClose/Race.java fails intermittently (aix) #21087

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

varada1110
Copy link
Contributor

@varada1110 varada1110 commented Sep 19, 2024

The preClose() method internally calls the dup2() system call. If there is a dup2() call on a file descriptor on a thread while another thread is blocked in a read/write operation on the same file descriptor, then the dup2() call is known to hang. Currently, preClose() experiences a hang because we call dup2() before killing the reader/writer thread(s). The workaround is to first kill the reader/writer thread(s) and then do the preClose() sequence. This reordering in the different channel implementations resolves the problem.

JBS Issue : JDK-8317801


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317801: java/net/Socket/asyncClose/Race.java fails intermittently (aix) (Bug - P4)

Contributors

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21087/head:pull/21087
$ git checkout pull/21087

Update a local copy of the PR:
$ git checkout pull/21087
$ git pull https://git.openjdk.org/jdk.git pull/21087/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21087

View PR using the GUI difftool:
$ git pr show -t 21087

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21087.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2024

👋 Welcome back varadam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 19, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8317801: java/net/Socket/asyncClose/Race.java fails intermittently (aix) 8317801: java/net/Socket/asyncClose/Race.java fails intermittently (aix) Sep 19, 2024
@openjdk
Copy link

openjdk bot commented Sep 19, 2024

@varada1110 The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@varada1110
Copy link
Contributor Author

/contributor add Shruthi.Shruthi1 [email protected]

@openjdk
Copy link

openjdk bot commented Sep 19, 2024

@varada1110
Contributor Shruthi.Shruthi1 <[email protected]> successfully added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant