-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8339772: serviceability/sa/TestJhsdbJstackUpcall.java fails on Linux ppc64le #21092
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
@TheRealMDoerr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 44 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@TheRealMDoerr The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
GHA Pre-submit test failures look unrelated ("Unable to download artifact(s)"). |
Thanks for the review! I think it can be considered trivial as it basically removes new code which has never worked. |
I'm not sure whether this PR is correct - if the app has several call stacks which do not compliant the ABI, this PR would not work. See #20789 (comment) for details. It is better to use JavaFrameAnchor like other platforms if we can. |
We don't support frames which don't follow the ABI. I think stopping the backtrace immediately is an appropriate reaction. Other debuggers like GDB would do the same. Nevertheless, I couldn't spot any bug in your new code. So, I've debugged the issue and found JDK-8340657 which causes the problem. |
Closing in favor of #21139. |
The SA model of the UpcallStub doesn't work reliably on PPC64. We can use the Backchain which works for all Power Architecture 64-Bit ELF ABI compliant frames. (The backtrace should stop when hitting a non-compliant frame which can occur with some compiler options. Also see comment in JBS issue.)
Note that this enables walking the native frames which is possible on PPC64, but not on some other platforms due to missing backlinks.
"test/hotspot/jtreg/serviceability" tests have passed with this PR.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21092/head:pull/21092
$ git checkout pull/21092
Update a local copy of the PR:
$ git checkout pull/21092
$ git pull https://git.openjdk.org/jdk.git pull/21092/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21092
View PR using the GUI difftool:
$ git pr show -t 21092
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21092.diff
Webrev
Link to Webrev Comment