Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8340436: Remove unused CompressedOops::AnyNarrowOopMode #21098

Closed

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Sep 19, 2024

Please review this trivial change to remove an unused enumerator.

Testing: mach5 tier1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340436: Remove unused CompressedOops::AnyNarrowOopMode (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21098/head:pull/21098
$ git checkout pull/21098

Update a local copy of the PR:
$ git checkout pull/21098
$ git pull https://git.openjdk.org/jdk.git pull/21098/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21098

View PR using the GUI difftool:
$ git pr show -t 21098

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21098.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2024

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 19, 2024

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340436: Remove unused CompressedOops::AnyNarrowOopMode

Reviewed-by: haosun, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 969c2af: 8339192: Native annotation parsing code of deprecated annotations causes crash
  • fdc16a3: 8340480: Bad copyright notices in changes from JDK-8339902

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 19, 2024
@openjdk
Copy link

openjdk bot commented Sep 19, 2024

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Sep 19, 2024

Webrevs

Copy link
Contributor

@shqking shqking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and trivial. Thanks

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 20, 2024
@kimbarrett
Copy link
Author

Thanks for reviews @shqking and @dholmes-ora

@kimbarrett
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 20, 2024

Going to push as commit 0f7d9e5.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 94c3317: 8339895: Open source several AWT focus tests - series 3
  • 969c2af: 8339192: Native annotation parsing code of deprecated annotations causes crash
  • fdc16a3: 8340480: Bad copyright notices in changes from JDK-8339902

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 20, 2024
@openjdk openjdk bot closed this Sep 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 20, 2024
@openjdk
Copy link

openjdk bot commented Sep 20, 2024

@kimbarrett Pushed as commit 0f7d9e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the remove-AnyNarrowOopMode branch September 20, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants