Skip to content

Commit

Permalink
Skip tests that use arff reading optimization for typecheck (#1185)
Browse files Browse the repository at this point in the history
Those types changed in the switch to parquet, and we need to
update the server parquet files and/or test expectations.
  • Loading branch information
PGijsbers authored Nov 25, 2022
1 parent 580b536 commit 5eb84ce
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tests/test_datasets/test_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ def test_get_data_pandas(self):
self.assertTrue(X[col_name].dtype.name == col_dtype[col_name])
self.assertTrue(y.dtype.name == col_dtype["survived"])

@pytest.mark.skip("https://github.com/openml/openml-python/issues/1157")
def test_get_data_boolean_pandas(self):
# test to check that we are converting properly True and False even
# with some inconsistency when dumping the data on openml
Expand Down Expand Up @@ -170,6 +171,7 @@ def _check_expected_type(self, dtype, is_cat, col):

self.assertEqual(dtype.name, expected_type)

@pytest.mark.skip("https://github.com/openml/openml-python/issues/1157")
def test_get_data_with_rowid(self):
self.dataset.row_id_attribute = "condition"
rval, _, categorical, _ = self.dataset.get_data(include_row_id=True)
Expand All @@ -196,6 +198,7 @@ def test_get_data_with_target_array(self):
self.assertEqual(len(attribute_names), 38)
self.assertNotIn("class", attribute_names)

@pytest.mark.skip("https://github.com/openml/openml-python/issues/1157")
def test_get_data_with_target_pandas(self):
X, y, categorical, attribute_names = self.dataset.get_data(target="class")
self.assertIsInstance(X, pd.DataFrame)
Expand All @@ -220,6 +223,7 @@ def test_get_data_rowid_and_ignore_and_target(self):
self.assertListEqual(categorical, cats)
self.assertEqual(y.shape, (898,))

@pytest.mark.skip("https://github.com/openml/openml-python/issues/1157")
def test_get_data_with_ignore_attributes(self):
self.dataset.ignore_attribute = ["condition"]
rval, _, categorical, _ = self.dataset.get_data(include_ignore_attribute=True)
Expand Down

0 comments on commit 5eb84ce

Please sign in to comment.