Some bug fixes related to building missing residues #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of my changes are related to this where I want to be able to specify the missing residues using
REMARK 465
sections. For now, I createchainWithGapsOverride
in my own software (an old version is in issue #170) because it's quite complex and because I'm not sure if/how PDBFixer/OpenMM could/should extract and save theREMARK 465
section from the original pdb.I did make one change to
chainWithGaps
corresponding to the situation where there are waters following the sequence -- their presence was preventing the "alignment" step infindMissingResidues
from working. I obviously don't have a list of all possible ligands and I don't want to examine CONECT records, but the approach of "known" residues seems ok to me.This addresses an unreported issue of insertionCodes for not-missing residues are not preserved.
One problem I've not taken on is that
REMARK 465
's specified resnum and insertion code are not necessarily preserved by_addMissingResiduesToChain
. Seems minor and I don't have any tests cases for that right now.This also addresses #175