Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some bug fixes related to building missing residues #178

Closed
wants to merge 3 commits into from

Conversation

nitroamos
Copy link

Some of my changes are related to this where I want to be able to specify the missing residues using REMARK 465 sections. For now, I create chainWithGapsOverride in my own software (an old version is in issue #170) because it's quite complex and because I'm not sure if/how PDBFixer/OpenMM could/should extract and save the REMARK 465 section from the original pdb.

I did make one change to chainWithGaps corresponding to the situation where there are waters following the sequence -- their presence was preventing the "alignment" step in findMissingResidues from working. I obviously don't have a list of all possible ligands and I don't want to examine CONECT records, but the approach of "known" residues seems ok to me.

This addresses an unreported issue of insertionCodes for not-missing residues are not preserved.

One problem I've not taken on is that REMARK 465's specified resnum and insertion code are not necessarily preserved by _addMissingResiduesToChain. Seems minor and I don't have any tests cases for that right now.

This also addresses #175

@jchodera
Copy link
Member

@peastman: Should this be reviewed and merged?

@JoaoRodrigues
Copy link
Contributor

Just to add that I am running into a similar issue and a patch like this could be potentially very useful. In my situtation, PDBFixer cannot add caps to the middle of a structure (in case it has gaps, this is sometimes useful before dynamics).

I cannot say this is a perfect solution, would need more time to check it thoroughly, but just adding my 2 cents that this is an important issue.

@peastman
Copy link
Member

peastman commented Jan 9, 2019

Sorry I've been so bad about replying to this. I kept meaning to reply but not doing it, and then I was traveling, and then I was on vacation. Sorry!

Anyway, I agree with you. This is an important issue, but I'm not convinced this is exactly the right solution. Could you open an issue describing exactly what you see as the important issues and requirements? Let's discuss what is the best way of solving it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants