Install oc without external action #402
Conversation
The redhat-actions/openshift-tools-installer is experiencing slowness when installing oc. This steps can take up to 3 minutes. More info: redhat-actions/openshift-tools-installer#105 Using a custom script reduces the installation of oc to less than 10s. Signed-off-by: Matthias Goerens <[email protected]>
There was a problem hiding this comment.
1). Remove progress bar flags
2). Should we consider making this a reusable action? I know we also pull oc down in chart-verifier's CI. https://github.com/redhat-certification/chart-verifier/blob/main/.github/workflows/build.yaml#L83-L91
3). Does adding this to $GITHUB_PATH add it to the end or the beginning of the resolution? Just want to make sure we won't get an oc that comes up sooner in the path than what we're installing.
| with: | ||
| oc: latest | ||
| run: | | ||
| wget --progress=dot:mega https://mirror.openshift.com/pub/openshift-v4/clients/ocp/latest/openshift-client-linux.tar.gz |
There was a problem hiding this comment.
Probably don't need --progress in CI.
| run: | | ||
| wget --progress=dot:mega https://mirror.openshift.com/pub/openshift-v4/clients/ocp/latest/openshift-client-linux.tar.gz | ||
| tar -zxvf openshift-client-linux.tar.gz oc -C . | ||
| echo "$PWD/oc" >> $GITHUB_PATH |
There was a problem hiding this comment.
You prefer this to symlinking to /usr/local/bin/?
| tar -zxvf openshift-client-linux.tar.gz oc -C . | ||
| echo "$PWD/oc" >> $GITHUB_PATH | ||
| rm -f openshift-client-linux.tar.gz | ||
| oc version |
There was a problem hiding this comment.
Pass the --client flag here. We don't care about server details here.
|
@komish First off, I want to briefly address the pertinence of this PR. Do we want to (a) implement this workaround, or (b) investigate the upstream action ? In favor of (a):
In favor of (b):
I will answer your other comments at a later time |
|
I'd love to use the tools installer, but it's mostly in a maintenance mode. Debugging the last arbitrary 3m wait was non-trivial for me, as I'm not overly engaged in the TypeScript ecosystem. I'm open to taking our own path for installing this client in our CI. |
The redhat-actions/openshift-tools-installer is experiencing slowness when installing oc. This steps can take up to 3 minutes. More info: redhat-actions/openshift-tools-installer#105
Using a custom script reduces the installation of oc to less than 10s.