fix: keep request_hashe consistent #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1254 +/- ##
===========================================
+ Coverage 80.75% 90.96% +10.20%
===========================================
Files 15 13 -2
Lines 977 1184 +207
===========================================
+ Hits 789 1077 +288
+ Misses 188 107 -81 ☔ View full report in Codecov by Sentry. |
efahl
reviewed
Feb 15, 2025
asu/util.py
Outdated
| return get_str_hash( | ||
| " ".join( | ||
| sorted( | ||
| list( |
There was a problem hiding this comment.
You can get rid of the list() as sorted automatically converts the set to a list...
return get_str_hash(" ".join(sorted(set(x.removeprefix("+") for x in packages))))
|
Tested and works as expected. |
Signed-off-by: Paul Spooren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.