dns: support legacy queries #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, in case the query is of the type "One-Shot Multicast DNS Queries", the questions also need to be sent along with the answer, like a conventional DNS response (RFC 6762 Section 6.7). Therefore, we save the question section while parsing DNS question. Signed-off-by: Mohd Husaam Mehdi <[email protected]>
As per RFC 6762 Section 6.7 (Legacy Unicast Responses) "If the source UDP port in a received Multicast DNS query is not port 5353, this indicates that the querier originating the query is a simple resolver such as described in Section 5.1, "One-Shot Multicast DNS Queries", which does not fully implement all of Multicast DNS. In this case, the Multicast DNS responder MUST send a UDP response directly back to the querier, via unicast, to the query packet's source IP address and port. This unicast response MUST be a conventional unicast response as would be generated by a conventional Unicast DNS server; for example, it MUST repeat the query ID and the question given in the query message." Therefore, umdns should not ignore DNS questions coming from non- multicast sources, and also provide question section which is not usually provided in mDNS responses. Signed-off-by: Mohd Husaam Mehdi <[email protected]>
mhusaam
force-pushed
the
for_mdns_legacy_queries
branch
from
6079636 to
f057643
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.