-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#56779] Allow empty lines in rich text #16620
Draft
as-op
wants to merge
13
commits into
dev
Choose a base branch
from
feature/56779-allow-empty-lines-in-rich-text
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…down root level; support blank lines in tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/work_packages/56779
What are you trying to accomplish?
Allow empty lines everywhere in our rich text (markdown with html)
Screenshots
What approach did you choose and why?
Support blank lines on markdown root level
Markdown does not support multiple blank lines. So I adapted the format supported by most markdown parsers/renderers.
(
First line\n\n<br>\n\n<br>\n\nFourth line
)compatible with:
Support blank lines in table cells
We store tables as HTML, so we just need to preserve empty lines as paragraphs
<p><br></p>
compatible with:
Support blank lines in lists
As for empty lines on root level, blank lines in lists are not supported by markdown, therefor we use the same method.
compatible with:
Support blank lines in code blocks
Empty markdown code blocks are inflated to have at least one empty line
compatible with:
GIthub
markdown => HTML pipeline in OpenProject
markdown => html => CKeditor conversion support added
CKeditor => html => markdown conversion support added
Check md-to-pdf
Merge checklist