Adds some missing services to Storages along with logging. #16748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mereghost
force-pushed
the
impl/add-storage-missing-services
branch
from
27d273a
to
3214cd7
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -18,8 +18,8 @@ | |||
| <% header.with_description(test_selector: 'storage-new-page-header--description') do %> | |||
| <%= | |||
| t("storages.instructions.new_storage", | |||
| provider_link: ::OpenProject::Static::Links[:storage_docs][:"#{@storage.short_provider_type}_setup"][:href].html_safe, | |||
| provider_name: I18n.t("storages.provider_types.#{@storage.short_provider_type}.name") | |||
| provider_link: ::OpenProject::Static::Links[:storage_docs][:"#{@storage}_setup"][:href].html_safe, | |||
Check notice
Code scanning / Brakeman
Unescaped model attribute. Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the last steps on the Logging and Error Message Improvements on Storages. Of course there's always space for improvements, but all the major issue causing steps are covered.
This PR also does some cleanup over our code.
Related WP: OP#56354