Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/57577 broken ordering by multi value custom fields #16762

Draft
wants to merge 28 commits into
base: dev
Choose a base branch
from
Draft

Bug/57577 broken ordering by multi value custom fields #16762

wants to merge 28 commits into from

Conversation

toy
Copy link
Contributor

@toy toy commented Sep 19, 2024

Ticket

OP#57577

What are you trying to accomplish?

Screenshots

What approach did you choose and why?

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@toy
[#57537] Copy specs for work packages ordering by custom fields to pr…
92bcb6f 
…ojects

https://community.openproject.org/work_packages/57537
@toy
remove select forcing only order statements to be returned by default…
3a63b2a 
… for custom field order
@toy
also remove selecting lower project name in name_order
d176b9b
@toy
custom_field factory multi_value trait
6439653
@toy
specs for projects ordering by custom field adapted from work packages
3fc8072
@toy
ensure Queries::Projects::Selects::Default.key matches exactly
1aeafb3
@toy
ensure Queries::Projects::Selects::CustomField.key matches exactly
1d96bac
@toy
shorten variable name
5df243e
@toy
rework test for Queries::Projects::Orders::CustomFieldOrder#available?
8605c3d
@toy
ensure Queries::Projects::Orders::CustomFieldOrder.key matches exactly
d55f200
@toy
test Queries::Projects::Selects::CustomField#custom_field
3e32485
@toy
fix memoization in Queries::Projects::Selects::CustomField#custom_field
de4c981
@toy
extract key as constant and simplify usage
8d2cda9
@toy
test Queries::Projects::Orders::CustomFieldOrder#custom_field
244a69c
@toy
extract scope in Queries::Projects::Orders::CustomFieldOrder
4590820
@toy
fix memoization in Queries::Projects::Orders::CustomFieldOrder
7d3c647
@toy
fix how available custom fields are stubbed in a spec
0932d25
@toy
[#57577] Broken ordering by multi value custom fields
e79ad9f 
https://community.openproject.org/work_packages/57577
@toy
Merge branch 'task/57537-copy-specs-for-work-packages-ordering-by-cus…
6c472fe 
…tom-fields-to-projects' into bug/57577-broken-ordering-by-multi-value-custom-fields
@toy
use array to order by user custom field instead of 3 order statements
325cd89 
Switch to using mail instead of id as agreed, as array can't contain
different types and mail is an unique string. This should not be a
security concern, as minimal information is exposed
@toy
use quoted_table_name instead of table_name
f66c05d
@toy
inline version column as it is always and only name
e183d44
@toy
eq_array matcher to be able to see a diff
1792d51
@toy
use eq_array matcher to see difference in order when ordering by cust…
754e021 
…om field is unexpected
@toy
fix ordering of multi value list custom fields
8d14a91
@toy
fix variable name
9aa8bc8
@toy
test ordering of objects with same values in different order
c108939
@toy
remove duplication in list custom field ordering
8b910da
@toy toy marked this pull request as draft September 19, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@toy