Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO/VTK: add support for writing time series #432

Merged
merged 20 commits into from
Dec 13, 2023
Merged

Conversation

andrea-iob
Copy link
Member

The VTK class is now able to write PVD files containing the information about the time series.

@ksamouchos
Copy link
Contributor

There is a typo in the comment of commit f769f3a :

"return an invalid counter is a file is not in a time series"

@andrea-iob
Copy link
Member Author

There is a typo in the comment of commit f769f3a :

"return an invalid counter is a file is not in a time series"

Fixed.

@andrea-iob
Copy link
Member Author

I've fixed the generation of PVD collection for parallel cases.

Copy link
Contributor

@ksamouchos ksamouchos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit history was very helpful. The code was tested by running immerflow branch of pull request https://github.com/optimad/immerflow/pull/747 .

@andrea-iob andrea-iob merged commit 4bfdf0d into master Dec 13, 2023
@andrea-iob andrea-iob deleted the io.vtk.time.series branch December 13, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants