-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RBF: add linear polynomial term in RBF interpolation #434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just optional, if you can, please improve the test 00004 considering variable support radii instead of a homogeneous one.
You have mixed tons of cosmetic changes with the functional changes associated with the pull request. It's hard for me to understand what are the real changes. I'll leave the review to @roccoarpa and @kgkara. |
Please squash together all the commits before merging. |
Ah, yes, sorry for that. It was clang-format enabled for modified code. If you want I can try to isolate format changes with implementations. |
2ccbe05
to
1ae188b
Compare
The new forced pushed branch should be cleaned of formatting modifications. |
1ae188b
to
a6a2355
Compare
The pull introduces a regularization linear multivariate polynomial to the RBF basis during RBF interpolation.
The polynomial is based on the btipit class ReconstructionPolynomial and specialized only for a first degree polynomial.
Configurations of RBF nodes leading to undetermined linear systems, because identical rows/columns provided by polynomial basis terms, are automatically managed by reduction of the variables of the multivariate polynomial.
A custom class derived by RBFKernel has now to override new pure virtual methods aimed to the initialization of the polynomial, the identification of the independent variables and the evaluation of the polynomial basis.
A new integration test is added: test_RBF_00004.