Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBF: add linear polynomial term in RBF interpolation #434

Merged
merged 9 commits into from
Dec 7, 2023

Conversation

edoardolombardi
Copy link
Member

The pull introduces a regularization linear multivariate polynomial to the RBF basis during RBF interpolation.

The polynomial is based on the btipit class ReconstructionPolynomial and specialized only for a first degree polynomial.

Configurations of RBF nodes leading to undetermined linear systems, because identical rows/columns provided by polynomial basis terms, are automatically managed by reduction of the variables of the multivariate polynomial.

A custom class derived by RBFKernel has now to override new pure virtual methods aimed to the initialization of the polynomial, the identification of the independent variables and the evaluation of the polynomial basis.

A new integration test is added: test_RBF_00004.

Copy link
Contributor

@roccoarpa roccoarpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just optional, if you can, please improve the test 00004 considering variable support radii instead of a homogeneous one.

test/integration_tests/RBF/test_RBF_00004.cpp Outdated Show resolved Hide resolved
src/RBF/rbf.hpp Outdated Show resolved Hide resolved
test/integration_tests/RBF/test_RBF_00004.cpp Outdated Show resolved Hide resolved
src/RBF/rbf.hpp Outdated Show resolved Hide resolved
src/RBF/rbf.hpp Outdated Show resolved Hide resolved
@andrea-iob
Copy link
Member

You have mixed tons of cosmetic changes with the functional changes associated with the pull request. It's hard for me to understand what are the real changes. I'll leave the review to @roccoarpa and @kgkara.

@andrea-iob
Copy link
Member

Please squash together all the commits before merging.

@edoardolombardi
Copy link
Member Author

You have mixed tons of cosmetic changes with the functional changes associated with the pull request. It's hard for me to understand what are the real changes. I'll leave the review to @roccoarpa and @kgkara.

Ah, yes, sorry for that. It was clang-format enabled for modified code. If you want I can try to isolate format changes with implementations.

@edoardolombardi edoardolombardi force-pushed the rbf.add.linear.polynomial branch 3 times, most recently from 2ccbe05 to 1ae188b Compare December 4, 2023 19:01
@edoardolombardi
Copy link
Member Author

edoardolombardi commented Dec 4, 2023

The new forced pushed branch should be cleaned of formatting modifications.
Let me know if you'd like to add your review, @andrea-iob, thanks.

test/integration_tests/RBF/test_RBF_00003.cpp Outdated Show resolved Hide resolved
test/integration_tests/RBF/test_RBF_00003.cpp Outdated Show resolved Hide resolved
src/RBF/rbf.hpp Show resolved Hide resolved
src/RBF/rbf.cpp Outdated Show resolved Hide resolved
src/RBF/rbf.hpp Show resolved Hide resolved
src/RBF/rbf.cpp Outdated Show resolved Hide resolved
src/RBF/rbf.hpp Outdated Show resolved Hide resolved
src/RBF/rbf.cpp Outdated Show resolved Hide resolved
src/RBF/rbf.cpp Outdated Show resolved Hide resolved
@edoardolombardi edoardolombardi force-pushed the rbf.add.linear.polynomial branch from 1ae188b to a6a2355 Compare December 6, 2023 17:09
@edoardolombardi edoardolombardi merged commit fc91d33 into master Dec 7, 2023
@edoardolombardi edoardolombardi deleted the rbf.add.linear.polynomial branch December 7, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants