-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IO: use Boost library for reading/writing configuration files #442
Conversation
Hi, apologies, I prefer to leave the review to the others. |
600d0f8
to
ab5dac0
Compare
ab5dac0
to
81afc0f
Compare
The pull modifications are fine. Anyway, as it is, it's compiling only for Linux, even if its goal is to simplify the Windows compilation. Furthermore, as libxml2 and rapidjson library are no more needed, the download of them through Nuget tool during project configuration, as done in the mscv compliant branches should be removed. The pull should be merged together (or after, in any case rebased on) the complete support of Windows OS. |
This pull request is a preparatory step for adding Windows support and should be merged before adding Windows support. The branch the will allow to compile bitpit on Windows will start from here and will introduce the needed changes for adding Windows support. The sole purpose of these changes is to avoid using Nuget in that future branch (libxml2 and RapidJSON were working fine on Linux). |
In my opinion it's not a good practice coding preparatory developments for Windows without testing them on Windows. Indeed, in order to know if their introduction doesn't affect Windows compliant branch, we had to rebase it and test the library compiled on Windows for our purposes. |
Using boost allows to drop libxml2 and RapidJOSN dependencies. These two dependencies are tricky to install on Windows, dropping them will make it easy to install bitpit in Windows.